livepeer-log: remove livepeer-log #695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iameli-streams
changed the title
iameli-streams
force-pushed
the
eli/remove-livepeer-log
branch
from
aa9e431 to
190dda1
Compare
thomshutt
approved these changes
Oct 12, 2023
iameli-streams
commented
Oct 17, 2023
| @@ -70,6 +70,8 @@ RUN apt update && apt install -yqq \ | |||
| "$(if [ "$BUILD_TARGET" != "stripped" ]; then echo "gdb"; fi)" \ | |||
| && rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| # Most of ./scripts is for livepeer-in-a-box except livepeer-vmagent, which is used in production in Catalyst proper | |||
| ADD ./scripts/livepeer-vmagent /usr/local/bin | |||
There was a problem hiding this comment.
Note to self: need to add this script to the uploaded bundle too...
Merged
|
Closing in favor of #707 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on livepeer/mistserver#2.
One commit just removes livepeer-log and all of its dependencies. The other handles
livepeer-victoria-metrics -jandlivepeer-vmagent -j- previously livepeer-log injected their usage information but now we make use of a Bash wrapper script (atscripts/livepeer-vmagent) to handle-jand then invoke the vmagent binary itself, now present at./bin/lp-vmagent.