Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil render for binary #171

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Handle nil render for binary #171

merged 3 commits into from
Aug 26, 2024

Conversation

brendon9x
Copy link
Contributor

Closes #170

Added a nil guard and a test. I thought adding tests for all types but it didn't look like this repo has those vibes.

Fix an unhandled nil when rendering the binary type.
lib/kino/explorer.ex Outdated Show resolved Hide resolved
@josevalim josevalim merged commit f447c02 into livebook-dev:main Aug 26, 2024
1 check passed
@josevalim
Copy link
Contributor

💚 💙 💜 💛 ❤️

@brendon9x brendon9x deleted the handle-nil-render-for-binary branch August 26, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kino Explorer vulnerable to nil in binary column type.
2 participants