Added non-animated loading indicator

Added option to use a non-animated loading indicator. On battery-powered systems, the animated loading indicator uses too much power, especially when multiple instances of the applet are used. Closes #4.
liujed · Sep 21, 2024 · d02bdfb · d02bdfb
1 parent 16abff7
commit d02bdfb
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 5 deletions.
diff --git a/CHANGES b/CHANGES
@@ -1,3 +1,7 @@
+v0.4.1
+  * Added option to use a non-animated loading indicator, to reduce power usage
+    on battery-powered systems.
+
 v0.4
   * Ported Andreas Loos's version to Plasma 6.
   * Incorporated some improvements from Mircea Kitsune.

diff --git a/package/contents/config/main.xml b/package/contents/config/main.xml
@@ -18,6 +18,9 @@
         <entry name="listOpacity" type="Int">
             <default>80</default>
         </entry>
+        <entry name="animateBusyIndicator" type="Bool">
+            <default>true</default>
+        </entry>
     </group>
 
 </kcfg>
diff --git a/package/contents/ui/FullRepresentation.qml b/package/contents/ui/FullRepresentation.qml
@@ -2,6 +2,7 @@ import QtQuick 2.15
 import QtQml.XmlListModel
 import QtQuick.Controls
 
+import org.kde.kirigami as Kirigami
 import org.kde.plasma.core as PlasmaCore
 import org.kde.plasma.plasmoid
 
@@ -46,7 +47,7 @@ Item {
     XmlListModelRole { name: "description"; elementName: "description" }
     XmlListModelRole { name: "link"; elementName: "link" }
 
-    onStatusChanged: busyIndicator.running = true
+    onStatusChanged: busyIndicator.isBusy = true
   }
 
   Component {
@@ -55,7 +56,7 @@ Item {
       height: layout.height
       width: thefeed.width
       color: PlasmaCore.Theme.viewBackgroundColor
-      Component.onCompleted: busyIndicator.running = false
+      Component.onCompleted: busyIndicator.isBusy = false
 
       Item {
         height: layout.height
@@ -165,10 +166,34 @@ Item {
     snapMode: ListView.SnapToItem
   }
 
-  BusyIndicator {
+  Item {
     id: busyIndicator
-    running: true
+    property bool isBusy: true
+    property var animate: plasmoid.configuration.animateBusyIndicator
+
+    onAnimateChanged: updateIndicator()
+    onIsBusyChanged: updateIndicator()
+
     anchors.centerIn: parent
+
+    function updateIndicator() {
+      animated.running = isBusy && animate
+      icon.visible = isBusy && !animate
+    }
+
+    BusyIndicator {
+      id: animated
+      running: isBusy && animate
+      anchors.centerIn: parent
+    }
+
+    Kirigami.Icon {
+      id: icon
+      source: "view-refresh"
+      anchors.centerIn: parent
+      width: animated.width
+      height: width
+    }
   }
 
   Timer {

diff --git a/package/contents/ui/config/ConfigGeneral.qml b/package/contents/ui/config/ConfigGeneral.qml
@@ -8,6 +8,7 @@ Item {
   property alias cfg_url: url.text
   property alias cfg_headerColor: headerColorDialog.selectedColor
   property alias cfg_listOpacity: listOpacity.value
+  property alias cfg_animateBusyIndicator: animateBusyIndicator.checked
 
   GridLayout {
     id: generalConfig
@@ -35,7 +36,7 @@ Item {
     }
 
     Text {
-      text: "Header Color"
+      text: "Header colour"
     }
     Rectangle {
       id: headerColor
@@ -84,6 +85,13 @@ Item {
         return Math.round(Number.fromLocaleString(locale, text) * decimalFactor)
       }
     }
+
+    Text {
+    }
+    CheckBox {
+      id: animateBusyIndicator
+      text: "Use loading animation"
+    }
   }
 
   ColorDialog {