Author pages #81
Author pages #81
Conversation
1. Put a slug on author profiles so they can be looked up from a url. 2. Make an author page model that dynamically fetches author information based on the url.
This migration (mostly written by @cheryllium) takes AuthorProfiles to AuthorPages and also updates the data from the older model and reconstructs the relationships between BlogPages and their author.
1. If there's no about page (or more than one), then no data is migrated. 2. Also fix the line endings.
|
I think we should add icons to the social media links. People are fairly used to seeing them, such that it actually feels weirder to me not to see them. Also if you just want to find someone's twitter page, scanning for a bird is a lot faster than scanning for the word twitter. (If you want to have it not be duplicating info, you could even display usernames/URLs instead of just "Twitter/GitHub/Portfolio") |
|
Oh displaying usernames/URLs is a fine idea. Also UGH i guess we can camelcase GitHub. I'll make a separate issue for banner images |
|
@harrislapiroff You bring up good points. I am now in favor of @nmorduch 's suggestion of putting the icons and the text together, and I like the idea of displaying usernames/URLs! |
|
The author pages migration doesn't seem to be reversible. Maybe something to do with @chigby? |
Added banner images to author pages
Some models do not yet have migrations for the author pages. We should merge and deploy, _then_ change those fields.
|
We're having a weird migrations situation, so let's merge and deploy this branch, then make a few model changes and then deploy that. (This is because the author pages migration is janky.) |
|
Design-wise I would like for these links to be black or gray and for the photo to be part of the link: Otherwise... the trouble with migrations we've been having on this branch is suspect, but it seems to have worked OK on my computer. So technically I think this branch is OK to merge, but we should make sure we do it at a time when we all have bios prepped and someone is prepared to revert the database if needed. |
|
Cool cool maybe early next week? And then I'll do the rest of the work on this <3 |
|
Made the changes on the about page @harrislapiroff |
Changes in this branch: Added author pages and updated links throughout the site to link to them. Also removed media links in blog author bios.