UnixFS symbolic links targeting a path with .. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## routing #96 +/- ##
===========================================
+ Coverage 53.49% 54.42% +0.93%
===========================================
Files 75 75
Lines 4535 4564 +29
===========================================
+ Hits 2426 2484 +58
+ Misses 2109 2080 -29 ☔ View full report in Codecov by Sentry. |
John-LittleBearLabs
force-pushed
the
dotdot
branch
from
95d399b to
53b8326
Compare
John-LittleBearLabs
force-pushed
the
dotdot
branch
from
53b8326 to
49cf14e
Compare
John-LittleBearLabs
force-pushed
the
routing
branch
from
490df44 to
fd7e94f
Compare
John-LittleBearLabs
force-pushed
the
dotdot
branch
from
49cf14e to
849c87f
Compare
John-LittleBearLabs
force-pushed
the
routing
branch
from
fd7e94f to
b737b0e
Compare
John-LittleBearLabs
force-pushed
the
dotdot
branch
from
849c87f to
a2bdb89
Compare
John-LittleBearLabs
force-pushed
the
routing
branch
from
b737b0e to
ce1cc52
Compare
John-LittleBearLabs
force-pushed
the
dotdot
branch
from
a2bdb89 to
4fd2ab8
Compare
John-LittleBearLabs
force-pushed
the
routing
branch
from
ce1cc52 to
ae4cc31
Compare
a .. component, eh? Valid link target
John-LittleBearLabs
force-pushed
the
dotdot
branch
from
4fd2ab8 to
41fddd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to this point it hasn't been supported.
It's still the case that a series of ../../.. is not allowed to resolve to anything outside the content root.