Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences (plumbing) #93

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Preferences (plumbing) #93

merged 1 commit into from
Jan 29, 2024

Conversation

John-LittleBearLabs
Copy link
Collaborator

@John-LittleBearLabs John-LittleBearLabs commented Jan 2, 2024

Declare the first and perhaps most important preference. Save to disk as updates happen. UI for user edits to come later.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c536783) 63.21% compared to head (35d0f6a) 54.30%.

❗ Current head 35d0f6a differs from pull request most recent head 6c5a726. Consider uploading reports for the commit 6c5a726 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   63.21%   54.30%   -8.91%     
==========================================
  Files          69       74       +5     
  Lines        3099     4541    +1442     
==========================================
+ Hits         1959     2466     +507     
- Misses       1140     2075     +935     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

As if they're preferences
Persist feedback loop
@John-LittleBearLabs John-LittleBearLabs merged commit abe3de5 into main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants