More maintenance #130
Open
More maintenance #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-LittleBearLabs
force-pushed
the
protoc_lock
branch
from
001b370 to
ed888c7
Compare
John-LittleBearLabs
force-pushed
the
mai
branch
from
3f0d42d to
3459797
Compare
| @@ -13,7 +13,10 @@ class Hasher { | |||
| public: | |||
| virtual ~Hasher() noexcept {} | |||
|
|
|||
| virtual std::optional<std::vector<Byte>> hash(ByteView) = 0; | |||
| /*! @param bytes Bytes to hash | |||
| * @return The digest or nullopt if there was an error | |||
There was a problem hiding this comment.
Doxygen warnings about undocumented items is one of the "maintenance" items I do periodically.
John-LittleBearLabs
force-pushed
the
mai
branch
from
3459797 to
26f2c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another round of hygiene and maintenance.