Building with vanilla Clang #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
==========================================
+ Coverage 51.41% 51.47% +0.06%
==========================================
Files 806 807 +1
Lines 24893 24903 +10
Branches 2689 2690 +1
==========================================
+ Hits 12799 12820 +21
+ Misses 11086 11072 -14
- Partials 1008 1011 +3 ☔ View full report in Codecov by Sentry. |
John-LittleBearLabs
force-pushed
the
clang
branch
2 times, most recently
from
6511b3b to
1d0ecc3
Compare
| @@ -0,0 +1,2 @@ | |||
| set(CHROMIUM_COMPILER_FLAGS -nostdinc++ -fno-rtti) | |||
| set(WARNING_FLAGS -Wall -Wextra -Werror=return-type -Wno-error=enum-constexpr-conversion ) | |||
There was a problem hiding this comment.
This is the main thing in this PR.
non-Apple, vanilla Clang. Compiler ID. Fixes #122
John-LittleBearLabs
force-pushed
the
clang
branch
from
1d0ecc3 to
a23260f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable using
non-Apple, vanilla Clang.
Compiler ID.
Fixes #122