CMAKE_CLANG_TIDY #125
Merged
CMAKE_CLANG_TIDY #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is optional. Default off. Version not required. Fixes #123
| @@ -76,11 +76,12 @@ add_library(ipfs_client | |||
| ${sources} | |||
| ${headers} #Mostly for IDEs' sake - this used to be considered bad practice but... generator expressions and such | |||
| ) | |||
| if(CLANG_TIDY_EXE) | |||
| if(USE_CLANG_TIDY AND CLANG_TIDY_EXE) | |||
There was a problem hiding this comment.
This is the essence of the change that motivates the PR.
If the clang-tidy you have installed on the system is too old to handle the options in the.clang-tidy file... or not installed... the build should just continue without failing all over the place for failure to generate additional static-analysis warnings.
This is most important in some CI environments, and in particular the conan-center Windows builders have ancient clang-tidy installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is optional. Default off.
Version not required.
Fixes #123