Unescape #119
Merged
Unescape #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 50.49% 50.98% +0.48%
==========================================
Files 477 479 +2
Lines 16177 16207 +30
Branches 1758 1759 +1
==========================================
+ Hits 8169 8263 +94
+ Misses 7452 7387 -65
- Partials 556 557 +1 ☔ View full report in Codecov by Sentry. |
John-LittleBearLabs
force-pushed
the
brand
branch
from
6e42a39 to
cedd556
Compare
John-LittleBearLabs
force-pushed
the
unescape
branch
from
311726c to
3ec8a1f
Compare
John-LittleBearLabs
force-pushed
the
unescape
branch
from
3ec8a1f to
ea7e9d9
Compare
| @@ -25,10 +25,10 @@ std::string u::RoughlyUnescapeUrlComponent(std::string_view url_comp) { | |||
| if (c <= '9') { | |||
| return c - '0'; | |||
| } | |||
| if (c <= 'Z') { | |||
| return c - 'A'; | |||
There was a problem hiding this comment.
Here's the essential change of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug showed up while adding to unit test coverage as per the usual cycle.
Fixes #117
The default impl only:
not in Chromium.