Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding #116

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Branding #116

merged 1 commit into from
Sep 5, 2024

Conversation

John-LittleBearLabs
Copy link
Collaborator

VirtualBox_debian-11_21_08_2024_16_29_59

I know for a fact the branding is not 100%. The gaps are filled in with the pre-existing generic Chromium branding. Here are some I know about:

  • Images that would be too challenging to adapt, e.g. the cool animated SVG where the logo swirls in on itself
  • Images where I'm not sure how to do the conversion or where the image would show up, e.g. the Adobe Illustrator file that shows something like a splash screen that's mostly white but has the logo and the word "Chromium" in the middle
  • Images where the conversion resulted in something terribly awful, like the monochrome logo (looked like an ambiguous smudge)
  • The text "chromium-browser" shows up in the taskbar in Debian. Not sure where that text is coming from.
  • Things I left in-place quite on purpose, like the copyright notice still attributes it to "The Chromium Authors".

I'm nearly 100% sure there are things that were missed that I don't know about.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.50%. Comparing base (69fbf44) to head (cedd556).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   50.38%   50.50%   +0.12%     
==========================================
  Files         477      477              
  Lines       16145    16177      +32     
  Branches     1756     1758       +2     
==========================================
+ Hits         8135     8171      +36     
+ Misses       7455     7451       -4     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

if not branding_dir:
verbose("Branding turned off via emptyBRANDING_DIR.")
elif isdir(branding_dir):
sync_dir(join(branding_dir, 'installer'), join('chrome', 'installer'), False)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably the most pivotal part of this PR.

Set BRANDING_DIR at configure.
Partial is good enough.
@John-LittleBearLabs John-LittleBearLabs merged commit bff1b28 into main Sep 5, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants