HTTP-like

Response Headers
Reintroduced/Fixed

.clang-format

@@ -9,7 +9,8 @@ Standard: Cpp11
 
 # TODO(crbug.com/1392808): Remove when InsertBraces has been upstreamed into
 # the Chromium style (is implied by BasedOnStyle: Chromium).
-#InsertBraces: true
+InsertBraces: true
+InsertNewlineAtEOF: true
 
 # Make sure code like:
 # IPC_BEGIN_MESSAGE_MAP()
@@ -38,6 +39,3 @@ IPC_STRUCT_END|\
 IPC_STRUCT_TRAITS_END|\
 POLPARAMS_END|\
 PPAPI_END_MESSAGE_MAP$"
-
-# TODO: Remove this once clang-format r357700 is rolled in.
-JavaImportGroups: ['android', 'androidx', 'com', 'dalvik', 'junit', 'org', 'com.google.android.apps.chrome', 'org.chromium', 'java', 'javax']

.clang-tidy

@@ -1,17 +1,27 @@
 ---
+  # TODO(crbug.com/1282228): reenable google-readability-casting once it no
+  # longer has as many false-positives.
   Checks:          '-*,
                     bugprone-argument-comment,
                     bugprone-assert-side-effect,
+                    bugprone-bool-pointer-implicit-conversion,
                     bugprone-dangling-handle,
+                    bugprone-forward-declaration-namespace,
                     bugprone-inaccurate-erase,
                     bugprone-string-constructor,
                     bugprone-string-integer-assignment,
                     bugprone-undefined-memory-manipulation,
+                    bugprone-unique-ptr-array-mismatch,
                     bugprone-unused-raii,
                     bugprone-use-after-move,
+                    bugprone-virtual-near-miss,
                     google-build-explicit-make-pair,
+                    google-default-arguments,
                     google-explicit-constructor,
-                    google-readability-casting,
+                    google-objc-avoid-nsobject-new,
+                    google-upgrade-googletest-case,
+                    misc-misleading-identifier,
+                    misc-homoglyph,
                     modernize-avoid-bind,
                     modernize-concat-nested-namespaces,
                     modernize-loop-convert,
@@ -23,11 +33,13 @@
                     modernize-use-bool-literals,
                     modernize-use-default-member-init,
                     modernize-use-emplace,
+                    modernize-use-equals-default,
                     modernize-use-equals-delete,
                     modernize-use-noexcept,
                     modernize-use-nullptr,
                     modernize-use-override,
-                    modernize-use-transparent-functors'
+                    modernize-use-transparent-functors,
+                    readability-redundant-member-init'
   CheckOptions:
     - key:          bugprone-assert-side-effect.AssertMacros
       value:        assert,DCHECK
@@ -46,9 +58,8 @@
     # https://groups.google.com/a/chromium.org/g/cxx/c/noMMTNYiM0w .
     - key:          modernize-use-emplace.IgnoreImplicitConstructors
       value:        1
-    # crbug.com/1402090: until we support C++20 everywhere, we shouldn't be
-    # suggesting constructs that require C++20. Prefer base::Reversed.
-    # TODO(crbug.com/1404958): remove these once C++20 is everywhere.
+    # Use of `std::ranges::reverse_view` is inconsistent with
+    # Chromium style. Recommend `base::Reversed` instead.
     - key:          modernize-loop-convert.MakeReverseRangeFunction
       value:        base::Reversed
     - key:          modernize-loop-convert.MakeReverseRangeHeader

.github/tour.sh

@@ -1,6 +1,18 @@
 #!/bin/bash -ex
 echo Clone tester repo.
-git clone --single-branch --branch decomposed_context https://github.com/John-LittleBearLabs/ipfs_client_clitester.git
+git clone https://github.com/John-LittleBearLabs/ipfs_client_clitester.git
+for e in "${GITHUB_HEAD_REF}" "${GITHUB_REF}"
+do
+  if ! [ "${e}" ] && git -C ipfs_client_clitester checkout "compat/${e}"
+  then
+    echo "Using compat/${e}"
+    break
+  fi
+done
+
+grep -n . ipfs_client_clitester/conanfile.txt
+sed -i "s,ipfs_client/[0-9].*$,ipfs_client/$(./ipfs_chromium/cmake/version.py)," ipfs_client_clitester/conanfile.txt
+grep -n . ipfs_client_clitester/conanfile.txt
 
 echo Install dependencies.
 sudo apt-get update
@@ -44,7 +56,7 @@ function url_case() {
   echo "test case description =${4}"
   ll="${5-note}"
   echo "log level = ${ll}"
-  if timeout 360 ./tester_build/clitester "${ll}" "${1}://${2}"
+  if timeout 420 ./tester_build/clitester "${ll}" "${1}://${2}"
   then
     echo clitester exited with successful status
   else