Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature offset #151

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

michalzxc
Copy link

@michalzxc michalzxc commented Oct 24, 2024

My aircon is bad at reading the correct temperature, as the result my sensor temperature is never reaching set one, so added the "offset support":

climate:
  - platform: smartir
    name: LivingRoom Aircon
    unique_id: livingroom_aircon
    device_code: 1032
    controller_data:
      controller_type: Broadlink
      remote_entity: remote.ir_blaster1
      delay_secs: 0.5
      num_repeats: 3
    temperature_offset:
      heat: +1
      cool: -1
      auto: 1  
    temperature_sensor: sensor.multisensorlivingroom_temperature
    humidity_sensor: sensor.multisensorlivingroom_humidity
    power_sensor: binary_sensor.livingroom_aircon_status

It can be different for both heating and cooling (anything that matches the names of the modes from codes file)

@litinoveweedle
Copy link
Owner

Hello @michalzxc, thank you for your contribution. I did brief review of you PR and if I understand proposed changes correctly, you simply shift input temperature when selecting corresponding command.

While I understand your use case, I am not completely convinced that this has broad usage. Also there are alternative ways of doing it (like shifting commands in the code file itself - specially as this seem to be issue for given device type). So for now I lean towards no inheriting this PR - the ultimate reason is the goal to keep integration as simple as possible.

@michalzxc
Copy link
Author

michalzxc commented Dec 6, 2024

It is not per device type, more per device itself. All depends where the Aircon internal temperature sensor is located in the room.

One of my Aircons has a wired controller in the middle of the room, another next to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants