Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Panasonic S-100PK2E5B #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michalzxc
Copy link

@michalzxc michalzxc commented Oct 24, 2024

I mapped remote "CZ-RWS3" what might support much more models

Some modes don't support full range: like heat ends at 30 but cool you can set only to 27C, so I duplicated the nearest values to have 16 to 30 range for all modes. Similarly "fan_only" mode doesnt support temperatures at all, so I duplicated command for every temperature

"on" command is different for every variation of temperature and mode, but I used random read (24C Heat On), as it is overwritten either way, and project doesn't seems to support multiple "on"s either

@litinoveweedle
Copy link
Owner

hello @michalzxc, thank you for your PR. The unnecessary duplication of the codes is exactly something I try to avoid, even introducing new more flexible structure of the code files. One common example is, that in fan mode, temperatures are not supported. In that case only one command for the "-" temperature key shall be provided. Also if some temperatures are not supported in some modes there shall be no need to duplicate nearest values. Or do I miss something here?

@litinoveweedle
Copy link
Owner

Also for some strange reason your PR did not triggered any workflow checks.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants