Change the default behavior of Simulation.add_noise() #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This short PR addresses this #342 (comment) |
yusuke-takase
pushed a commit
that referenced
this pull request
Nov 23, 2024
* Simulation.add_noise uses self.random as default * CHANGELOG updated
ziotom78
added a commit
that referenced
this pull request
Nov 28, 2024
* angle correction for 1-detector-pointing due to wedge HWP * Code simplifications (distructive changes) around the pointing systematics * modifiy the `pointing_sys.py` * add add_hwp_rot_disturb * modify add_hwp_rot_disturb * update documents * add comments * refactoring * fix bug of __init__ * add comments * reverse gitignore and remove cmb maps * add detailed assertion comments * refactor: update pointing_sys imports and __all__ exports * destructive change on pointing_sys.py: update functionality for MPI * update docs * update docs, remove cmb * fix scanning.py assertion * merge master * add test of hwp pointing sys * update notebook * Reorganize the User’s manual (#342) * Use PyData as the default theme for docs and update Sphinx and deps * Rework the structure of the documentation * Merge `Bandpasses` chapter into Detector and split `Scanning` * Remove duplicated material * Add missing reference * Remove spurious comma * Fix the grammar of a few sentences * Fix grammar and broken links, update references where needed * example in the noise page included, argument random in Simulation.add_noise is now optional * removed part of last commit * [skip ci] Update CHANGELOG --------- Co-authored-by: Luca Pagano <[email protected]> * Focal plane visualizer and detector file generator (#345) * add plot_fp.py * ask duration_yr * CHANGELOG.md: Add entry for plot_fp.py implementation and its functionality * update README * add plot.fp.rst in docs * docs: Improve formatting and clarity in plot_fp.rst * Fix the formatting to make ruff happy --------- Co-authored-by: Yusuke Takase <[email protected]> Co-authored-by: Maurizio Tomasi <[email protected]> * Change the default behavior of Simulation.add_noise() (#349) * Simulation.add_noise uses self.random as default * CHANGELOG updated * reformat by ruff * Update plot usage GIF in README.md * Update focal plane visualization section header in plot_fp.rst * Remove unused __init__.py file from pointing_sys module * Refactor import statement in litebird_sim and adjust spin rate in simulation test * update pointing reference file * Add documentation for pointing systematics and introduce pointing_sys.rst * Add author Yusuke Takase to pyproject.toml * CHANGELOG.md: Update breaking changes for PointingSys and get_pointings functions * refactoring for ruff * update pointing sys notebooks * docs: update * remove `docs/build` --------- Co-authored-by: Nicolò Raffuzzi <[email protected]> Co-authored-by: Maurizio Tomasi <[email protected]> Co-authored-by: Luca Pagano <[email protected]> Co-authored-by: Yusuke Takase <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
Simulation.add_noise()uses self.random as default random number generator. The following syntax now works: