-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focal plane visualizer and detector file generator #345
Conversation
Hi @yusuke-takase , very lovely, I like it! For me, it is a nice feature. If there are no objections, we can merge it. I would suggest a few things:
|
Thanks a lot, @ziotom78 !
I agree with this, and I can do it after #342 merged. Maybe it will be almost same description what we will write in README. |
Maybe you could add a short sub-section under the " Usage " section, where you put the description and image you posted in the topmost comment here. (Adding an image is an effective way to advertise things!) |
Hi @yusuke-takase , #342 has been merged in |
Thanks, @ziotom78 |
Hi @ziotom78 , |
* add plot_fp.py * ask duration_yr * CHANGELOG.md: Add entry for plot_fp.py implementation and its functionality * update README * add plot.fp.rst in docs * docs: Improve formatting and clarity in plot_fp.rst * Fix the formatting to make ruff happy --------- Co-authored-by: Yusuke Takase <[email protected]> Co-authored-by: Maurizio Tomasi <[email protected]>
* angle correction for 1-detector-pointing due to wedge HWP * Code simplifications (distructive changes) around the pointing systematics * modifiy the `pointing_sys.py` * add add_hwp_rot_disturb * modify add_hwp_rot_disturb * update documents * add comments * refactoring * fix bug of __init__ * add comments * reverse gitignore and remove cmb maps * add detailed assertion comments * refactor: update pointing_sys imports and __all__ exports * destructive change on pointing_sys.py: update functionality for MPI * update docs * update docs, remove cmb * fix scanning.py assertion * merge master * add test of hwp pointing sys * update notebook * Reorganize the User’s manual (#342) * Use PyData as the default theme for docs and update Sphinx and deps * Rework the structure of the documentation * Merge `Bandpasses` chapter into Detector and split `Scanning` * Remove duplicated material * Add missing reference * Remove spurious comma * Fix the grammar of a few sentences * Fix grammar and broken links, update references where needed * example in the noise page included, argument random in Simulation.add_noise is now optional * removed part of last commit * [skip ci] Update CHANGELOG --------- Co-authored-by: Luca Pagano <[email protected]> * Focal plane visualizer and detector file generator (#345) * add plot_fp.py * ask duration_yr * CHANGELOG.md: Add entry for plot_fp.py implementation and its functionality * update README * add plot.fp.rst in docs * docs: Improve formatting and clarity in plot_fp.rst * Fix the formatting to make ruff happy --------- Co-authored-by: Yusuke Takase <[email protected]> Co-authored-by: Maurizio Tomasi <[email protected]> * Change the default behavior of Simulation.add_noise() (#349) * Simulation.add_noise uses self.random as default * CHANGELOG updated * reformat by ruff * Update plot usage GIF in README.md * Update focal plane visualization section header in plot_fp.rst * Remove unused __init__.py file from pointing_sys module * Refactor import statement in litebird_sim and adjust spin rate in simulation test * update pointing reference file * Add documentation for pointing systematics and introduce pointing_sys.rst * Add author Yusuke Takase to pyproject.toml * CHANGELOG.md: Update breaking changes for PointingSys and get_pointings functions * refactoring for ruff * update pointing sys notebooks * docs: update * remove `docs/build` --------- Co-authored-by: Nicolò Raffuzzi <[email protected]> Co-authored-by: Maurizio Tomasi <[email protected]> Co-authored-by: Luca Pagano <[email protected]> Co-authored-by: Yusuke Takase <[email protected]>
I often want to know information about the detector by specifying the FPU's location.
Furthermore, I thought it would be even better if I could create a file with a list of detectors from the visual information, assuming an e2e simulation.
So, I would like to propose this functionality in litebird_sim.
I made
plot_fp.py
which can be executed byThen, this kind of conversation will be happened:
During this conversation, the function loads IMO which is installed in the local machine, and the FPU which is specified in the conversation will be visualized like this:
By the clicking, the
DetectorInfo
is shown in right in real time.Furthermore, detectors that were clicked and ‘starred’ when the plot was closed are saved to a file with the following content:
It will be the input of the e2e simulation and I hope it is useful for everyone.
How do you guys think this functionality?