Skip to content

Commit

Permalink
(wip)
Browse files Browse the repository at this point in the history
Related: xmonad#396
Related: xmonad#109
  • Loading branch information
liskin committed Nov 5, 2020
1 parent 3481e63 commit adddfb4
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 14 deletions.
27 changes: 14 additions & 13 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,25 @@

* `XMonad.Hooks.EwmhDesktops`

It is no longer recommended to use `fullscreenEventHook` directly.
Instead, use `ewmhFullscreen` which additionally advertises fullscreen
support in `_NET_SUPPORTED` and fixes fullscreening of applications that
explicitly check it, e.g. mupdf-gl, sxiv, …
- It is no longer recommended to use `fullscreenEventHook` directly.
Instead, use `ewmhFullscreen` which additionally advertises fullscreen
support in `_NET_SUPPORTED` and fixes fullscreening of applications that
explicitly check it, e.g. mupdf-gl, sxiv, …

`XMonad.Layout.Fullscreen.fullscreenSupport` now advertises it as well,
and no configuration changes are required in this case.
`XMonad.Layout.Fullscreen.fullscreenSupport` now advertises it as well,
and no configuration changes are required in this case.

TODO: integrate into `ewmh'` and enable by default

* `XMonad.Hooks.EwmhDesktops`
- `ewmh` function will use `logHook` for handling activated window. And now
by default window activation will do nothing.

`ewmh` function will use `logHook` for handling activated window. And now
by default window activation will do nothing.
You can use regular `ManageHook` combinators for changing window
activation behavior and then add resulting `ManageHook` using
`activateLogHook` to your `logHook`. Also, module `X.H.Focus` provides
additional combinators.

You can use regular `ManageHook` combinators for changing window
activation behavior and then add resulting `ManageHook` using
`activateLogHook` to your `logHook`. Also, module `X.H.Focus` provides
additional combinators.
TODO: refactor and update and make it not a breaking change

* `XMonad.Prompt.Directory`

Expand Down
8 changes: 7 additions & 1 deletion XMonad/Hooks/EwmhDesktops.hs
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ import XMonad.Util.WindowProperties (getProp32)
--
-- You may also be interested in 'docks' from "XMonad.Hooks.ManageDocks".
--
-- TODO: mention "XMonad.Hooks.UrgencyHook"
-- TODO: mention "XMonad.Hooks.Focus"

-- | TODO
Expand All @@ -77,7 +78,7 @@ data EwmhConfig = EwmhConfig
instance Default EwmhConfig where
def = EwmhConfig
{ workspaceListTransform = id
, activateHook = doFocus
, activateHook = doFocus -- TODO: urgency
}

-- | 'ewmh'' with default 'EwmhConfig'.
Expand Down Expand Up @@ -210,6 +211,11 @@ ewmhDesktopsEventHook = ewmhDesktopsEventHook' def
ewmhDesktopsEventHookCustom :: ([WindowSpace] -> [WindowSpace]) -> Event -> X All
ewmhDesktopsEventHookCustom f = ewmhDesktopsEventHook' def{ workspaceListTransform = f }

-- TODO: PureX, flicker
-- TODO: fullscreen flag
-- TODO: deprecate separate fullscreen and enable it by default, then move the
-- implementation to X.L.Fullscreen

-- |
-- Intercepts messages from pagers and similar applications and reacts on them.
-- Currently supports:
Expand Down
2 changes: 2 additions & 0 deletions XMonad/Hooks/Focus.hs
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,8 @@ data Focus = Focus
, currentWorkspace :: WorkspaceId
}
deriving (Show)

-- TODO: drop this
instance Default Focus where
def = Focus
{ focusedWindow = Nothing
Expand Down
2 changes: 2 additions & 0 deletions XMonad/Hooks/InsertPosition.hs
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
--
-----------------------------------------------------------------------------

-- TODO: note about XMonad.Hooks.Focus

module XMonad.Hooks.InsertPosition (
-- * Usage
-- $usage
Expand Down

0 comments on commit adddfb4

Please sign in to comment.