Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nil-check and translations #18

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Nil-check and translations #18

wants to merge 6 commits into from

Conversation

SwissalpS
Copy link

@SwissalpS SwissalpS commented Jan 21, 2022 •
edited
Loading

This commit adds

  • Tells player to which level tool has leveled up
    instead of just teasing
  • German translation
  • Spanish translation
  • French 'vous' to more informal 'tu'
  • Includes the nil-check by BuckarooBanzay

BuckarooBanzay and others added 2 commits September 29, 2021 21:52
@BuckarooBanzay
check groupcaps[].uses for nil
568944b
@SwissalpS
more info and languages
266f8ab 
This commit adds
- Tells player to which level tool has leveled up
  instead of just teasing
- German translation
- French 'vous' to more informal 'tu'
@SwissalpS SwissalpS changed the title Patch1 Nil-check and German translation Jan 21, 2022
Panquesito7
Panquesito7 suggested changes Jan 21, 2022
View reviewed changes
init.lua Outdated Show resolved Hide resolved
locale/toolranks.de.tr Outdated Show resolved Hide resolved
locale/toolranks.fr.tr Outdated Show resolved Hide resolved
@SwissalpS
Spanish translation
d582fcf 
Thanks El_Naso
@SwissalpS SwissalpS changed the title Nil-check and German translation Nil-check and translations Jan 21, 2022
@nonfreegithub
Copy link

nonfreegithub commented Sep 7, 2023 •
edited
Loading

can it be merged? it was approved

@louisroyer
Copy link
Contributor

louisroyer commented Sep 8, 2023 •
edited
Loading

The new french translation is entirely wrong.
You cannot use 'tu' in this context, it's either 'ton' (for 'outil', 'épée', ...), or 'ta' (for 'pioche', 'hache', ...) depending of @2, so 'votre' is more relevant since it can applies independently of @2.
And it should not be 'gagné un niveau au @4@5@6 !' but 'gagné un niveau et est maintenant niveau @4@5@6 !' (au means nothing in this context)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SwissalpS @nonfreegithub @louisroyer @Panquesito7 @BuckarooBanzay