Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Added tests #7

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

asantibanez
Copy link

@asantibanez asantibanez commented Feb 7, 2021

Summary

This PR adds tests for some of the package features.

Available tests:

  • Can subscribe to notifications
  • Can unsubscribe to notifications
  • WIP

Type of Change

  • 🚀 New Feature

Screenshot/Video

CI through Github Actions

image

Tests status

image

@asantibanez
Copy link
Author

Hi @liran-co

This is an excellent project. Kudos! 💪

I was on the same path on creating a similar package and found yours browsing Google. Would love to contribute with some testing for all features that are currently enabled.

Please let me know if this is something you are looking forward on having in your package to continue adding tests. I've added base setup and CI.

Regards,
Andrés

@liran-co
Copy link
Owner

liran-co commented Feb 7, 2021

Hi @asantibanez -

Appreciate the kind words. Yes, would love to have you contribute to the package in anyway you can. I haven't had the time to dedicate to tests on this, but if you can take it on, I'd be more than happy to have it merged in.

Liran

@asantibanez
Copy link
Author

Hey @liran-co

What Style CI are we using? Can you please share your config? Thanks!

@asantibanez
Copy link
Author

Hey @liran-co

Got almost all tests working! 💪

@liran-co
Copy link
Owner

Hey @asantibanez - sorry for the delay. I'm using the default PHP StyleCI config here: https://docs.styleci.io/multi-language#php-config. Going to check out these tests this weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants