DAT-19050: adding missing column is splitted on addColumn and add{Constraint} changetypes #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 20, 2024 11:56
…ngeTypes - addColumn and addDefaultValue
…n instead of default value itself
…ound it fails with similar error as default value for existing tables.
…ending bracket, default value sql generator to omit wraping numeric values in columns.
|
filipelautert
approved these changes
Nov 21, 2024
KushnirykOleh
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Databricks fails to add column to an existing delta table if there are defined default value or not null constraint. This was found by Pavlo and during my e2e test.
In this ticket for missing columns it was performed splitting of
addColumnChangeto three changesaddColumnChange,addDefaultValie,addNotNullConstraintChangeif they are required.Testing was performed with tables having different hanged default values, absent and unexpected columns.
As a test case i used run
diff-changelog, runupdatewith previously generated changelog file, run diff to make sure there are not changed entities left.