Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to sort alter relationship tables by name #655

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Douglas-K
Copy link
Contributor

@Douglas-K Douglas-K commented Nov 7, 2024

Change Description:

Enables the sorting of alter relationships tables by name, to make it easier to make manual corrections to the data at the Alter Relationships stage.

Additional "name sort" drop-down options are added for Related, Matched, Removed, and Added tables.

Notes:

  • enabling the built-in table sorting function with tbl.setSortingEnabled(True), doesn't seem to work as it appears to lose persistent connection between the visual table in QGIS (after sorting) and the database table in Postgres.
  • using a click listener with tbl.horizontalHeader().sectionClicked.connect(self.idBulk) and sorting with something like result.sort(key=lambda i: i[4], reverse = True), also doesn't seem to work.

Notes for Testing:

Bulk load some data, run Compare Outlines, then Alter Relationships. Click on the drop-down menu and choose one of the "name sort" options.

Source Code Documentation Tasks:

  • README updated (where applicable)
  • CHANGELOG (Unreleased section) updated
  • Docstrings / comments included to help explain code

User Documentation Tasks:

  • Confluence user guide updated (where applicable)

Testing Tasks:

  • Added tests that fail without this change
  • All tests are passing in development environment
  • Reviewers assigned
  • Linked to main issue for ZenHub board

@Douglas-K Douglas-K requested a review from jducnuigeen November 7, 2024 02:43
Copy link
Contributor

@jducnuigeen jducnuigeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ! Thanks !

@jducnuigeen jducnuigeen merged commit 8d8c5d2 into master Dec 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants