Fix SubmitSMResp unmarshalling when CommandStatus != data.ESME_ROK (#113

)
linxGnu · Sep 18, 2023 · 07a9190 · 07a9190
1 parent 42fdcca
commit 07a9190
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pdu/SubmitSMResp.go b/pdu/SubmitSMResp.go
@@ -51,9 +51,7 @@ func (c *SubmitSMResp) Marshal(b *ByteBuffer) {
 // Unmarshal implements PDU interface.
 func (c *SubmitSMResp) Unmarshal(b *ByteBuffer) error {
 	return c.base.unmarshal(b, func(b *ByteBuffer) (err error) {
-		if c.CommandStatus == data.ESME_ROK {
-			c.MessageID, err = b.ReadCString()
-		}
+		c.MessageID, err = b.ReadCString()
 		return
 	})
 }
diff --git a/receivable.go b/receivable.go
@@ -114,6 +114,7 @@ func (t *receivable) handleOrClose(p pdu.PDU) (closing bool) {
 			}
 			return
 		}
+
 		switch pp := p.(type) {
 		case *pdu.EnquireLink:
 			if t.settings.response != nil {
-Original file line number
+Diff line change
@@ Expand Up @@
     			}
     			return
     		}
     		switch pp := p.(type) {
     		case *pdu.EnquireLink:
     			if t.settings.response != nil {
@@ Expand Down @@