Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: add Huion KeyDial K20 #827

Merged
merged 2 commits into from
Nov 10, 2024
Merged

data: add Huion KeyDial K20 #827

merged 2 commits into from
Nov 10, 2024

Conversation

whot
Copy link
Member

@whot whot commented Nov 7, 2024

This is the successor to the KD100 and optically the same so these files are copy/paste from the KD100

@Deevad has a nicer-looking svg in udev-hid-bpf#35 but unfortunately that one requires a lot of manual fixes for the various CSS classes and object IDs we require. In the interest of getting this done quickly, here's a copy/pasted one that's been modified quickly.

This is a draft because I haven't yet been able to convince gnome settings to show the OSD

@Deevad
Copy link

Deevad commented Nov 7, 2024

Thank you very much!

I also posted a SVG I made on the udev-ebpf thread. Mine is still not cleaned (I can't still run the cleanup python script) but maybe you can enhance the layout you just merged with some element copy/pasted from mine (like the silhouette of the case).

The SVG: huion-kdial-mini-K20_inkscape-source.svg

huion-kdial-mini-K20_inkscape-source

Fixes "AttributeError: 'NoneType' object has no attribute 'split'"
@whot
Copy link
Member Author

whot commented Nov 7, 2024

Thanks, I do like your SVG better but it needs a fair bit of fixup to pass the test (see #829 to make the tests provide some useful output). I played with it yesterday but ran of out time because there's too much of it... the simple fixes were s|Ring|Dial|g to but then all the buttons need fixes. And running clean_svg.py on the device moves the mode-switch button around for unknown reasons, it's quite frustrating. Either way, right now I'd prefer we have something so we can easily test with the various branch tips instead of having custom branches everywhere.

@Deevad
Copy link

Deevad commented Nov 7, 2024

Yes, I 100% agree. I was just suggesting to copy/paste the case outlines of my SVG on top of your SVG design just for decorating yours. But it is of course super optional.

This is the successor to the KD100 and optically the same so these files
are copy/paste from the KD100
@whot
Copy link
Member Author

whot commented Nov 8, 2024

. I was just suggesting to copy/paste the case outlines of my SVG on top of your SVG design just for decorating yours

good idea, done now. This makes it a bit different to the other tablets which do not have an outline but it looks pretty terrible without it so let's see if anyone complains...

@Deevad
Copy link

Deevad commented Nov 8, 2024

good idea, done now.

Thank you!

@whot whot marked this pull request as ready for review November 8, 2024 02:17
@whot
Copy link
Member Author

whot commented Nov 8, 2024

Ok, got this all to work - the dial is missing but that's a factor of the gnome and wayland stack not yet supporting relative dials. So we're good to merge this IMO

@Deevad
Copy link

Deevad commented Nov 8, 2024

So we're good to merge this IMO

Sure. Thank you for merging it.

@whot whot merged commit e91c544 into linuxwacom:master Nov 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants