-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data: add Huion KeyDial K20 #827
Conversation
Thank you very much! I also posted a SVG I made on the udev-ebpf thread. Mine is still not cleaned (I can't still run the cleanup python script) but maybe you can enhance the layout you just merged with some element copy/pasted from mine (like the silhouette of the case). |
Fixes "AttributeError: 'NoneType' object has no attribute 'split'"
Thanks, I do like your SVG better but it needs a fair bit of fixup to pass the test (see #829 to make the tests provide some useful output). I played with it yesterday but ran of out time because there's too much of it... the simple fixes were |
Yes, I 100% agree. I was just suggesting to copy/paste the case outlines of my SVG on top of your SVG design just for decorating yours. But it is of course super optional. |
This is the successor to the KD100 and optically the same so these files are copy/paste from the KD100
good idea, done now. This makes it a bit different to the other tablets which do not have an outline but it looks pretty terrible without it so let's see if anyone complains... |
Thank you! |
Ok, got this all to work - the dial is missing but that's a factor of the gnome and wayland stack not yet supporting relative dials. So we're good to merge this IMO |
Sure. Thank you for merging it. |
This is the successor to the KD100 and optically the same so these files are copy/paste from the KD100
@Deevad has a nicer-looking svg in udev-hid-bpf#35 but unfortunately that one requires a lot of manual fixes for the various CSS classes and object IDs we require. In the interest of getting this done quickly, here's a copy/pasted one that's been modified quickly.
This is a draft because I haven't yet been able to convince gnome settings to show the OSD