Fix id mangling in clean-svg #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently unused by easy to add now by just adding logger.debug() statements.
Otherwise this script fails on machines where there is no python symlink installed.
The theory (I think) here is that we can have a group "A" that then applies to each subsequent element automatically without having to indidivually name those elements. This is both buggy and unnecessary and it completely breaks SVG files generated by inkscape (1.4 at least) which will automatically assign a group ID like "g1" to the group - resulting in our buttons etc. all labeled as "Buttong1". Remove this "feature".
whot
force-pushed
the
wip/clean-svg-fixes
branch
from
19e633a to
25c4adc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.