Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to clean-svg.py #799

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fixes to clean-svg.py #799

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0ddb1a
tools/clean_svg: do not convert plain integers to floats
bentiss Oct 15, 2024
66cf4cb
tools/clean_svg: do not remove an elem while iterating on a list
bentiss Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tools/clean_svg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@

def human_round(number):
"""
Round to closest .5
Round to closest .5, keep integer values
"""
return round(number * 2) / 2.0
v = round(number * 2) / 2.0
return int(v) if v == int(v) else v


def traverse_and_clean(node):
Expand Down Expand Up @@ -83,7 +84,7 @@ def round_if_number(value):
def remove_non_svg_nodes_and_strip_namespace(root):
if root.tag.startswith(BRACKETS_NAMESPACE):
root.tag = root.tag[len(BRACKETS_NAMESPACE) :]
for elem in root:
for elem in list(root):
if (
not elem.tag.startswith(BRACKETS_NAMESPACE)
or elem.tag == BRACKETS_NAMESPACE + "metadata"
Expand Down