This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
include configs of other nginx modules (ie. stream, mail) #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can an admin please whisper to jenkins to test this PR. |
|
Thanks for the PR, but I'd rather not overcomplicate things. I think it's rare for users to have mail or stream blocks and if they do, they can add to nginx.conf. The default nginx.conf already contains a commented out sample mail block. I personally added a stream block for vpn into mine, and it was only 9 lines. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks, team linuxserver.io