Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next] Add basic weather information to screensaver #464

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

queenkjuul
Copy link

@queenkjuul queenkjuul commented Nov 21, 2024

Weather Widget for cinnamon-screensaver

Adds a new type of floating widget (similar to Clock and AlbumArt) that displays a weather icon alongside the current weather conditions. Utilizes OpenWeatherMap for weather data and GeoJS.io for location data. Models and interfaces are designed to be mostly compatible with the Weather applet in cinnamon-spices-applets/weather@mockturtl so that additional Weather and Location providers can be easily added.

The OpenWeatherMap API key from the cinnamon-spices-applets has been reused to enable out-of-the-box operation.

Dependencies

App will crash until the dconf schema is updated.

PR with the new schema in cinnamon-desktop is here:

linuxmint/cinnamon-desktop#246

PR with updated cinnamon-settings screensaver module here:

linuxmint/cinnamon#12516

In the meantime:

  1. download the new schema file from the above PR
  2. Backup /usr/share/glib-2.0/schemas/org.cinnamon.desktop.screensaver.gschema.xml
  3. Move the downloaded org.cinnamon.desktop.screensaver.gschema.xml.in file to /usr/share/glib-2.0/schemas/org.cinnamon.desktop.screensaver.gschema.xml (rename it to remove the .in at the end)
  4. run sudo glib-compile-schemas /usr/share/glib-2.0/schemas/
  5. use dconf-editor or another means to set the relevant settings in org.cinnamon.desktop.screensaver

image

@leigh123linux
Copy link
Contributor

Please squash the commits.

Get basic temperature, conditions, location working with scaled icon

Code cleanup

Add IP Geolocation to weather component

Cleanup, settings integrations, bugfixes, translation

Fix Localization

cleanup
@queenkjuul
Copy link
Author

Please squash the commits.

all done. cleaned up some formatting too. Double-checked, seems ok from here (feedback welcome of course)

@clefebvre
Copy link
Member

Ok, first things first, this is pretty cool :)

I don't want this to get into Cinnamon at the last minute. I think we should think about how weather is integrated as a whole into the desktop.. because this spans across an applet, a desklet, a screensaver.. which all deserve to be part of the Cinnamon core.

In 6.4 we're also introducing Night Light.. and that (for the moment) reads our system timezone, but it also could potentially let the user define a position or calculate a position using geoip... and that's something which is quite global, as it can be useful here again for this weather-related set of features.

Anyway, all this to say let's postpone this and give ourselves another 6 months to think about it.

@clefebvre clefebvre changed the title Add basic weather information to screensaver [Next] Add basic weather information to screensaver Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants