Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change tips color and update immutable config #288

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

rb-union
Copy link
Contributor

@rb-union rb-union commented Dec 6, 2024

fix: change tips color when theme changed

As title.

Log: change tips color when theme changed
Bug: https://pms.uniontech.com/bug-view-292139.html
Influence: UI

feat: update immutable config

As title.

Log: Update immutable config.

As title.

Log: change tips color when theme changed
Bug: https://pms.uniontech.com/bug-view-292139.html
Influence: UI
As title.

Log: Update immutable config.
@rb-union rb-union changed the title fix: change tips color when theme changed fix: change tips color and update immutable config Dec 6, 2024
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. installDebThread.cpp文件中,新增的kImmuEnvEnableWait常量应该有注释说明其用途,以便其他开发者理解其作用。
  2. immutable_backend.cpp文件中,kImmutableEnable常量的注释应该更新,以反映其实际的用途和返回值格式。
  3. filechoosewidget.cpp文件中,themeChanged函数中新增的代码应该有注释说明其目的,以便其他开发者理解其作用。

代码质量改进:

  1. installDebThread.cpp文件中,immutableProcess函数中的return语句应该有注释说明其用途,以便其他开发者理解其作用。
  2. immutable_backend.cpp文件中,ImmutableBackend类的构造函数中应该有注释说明其用途,以便其他开发者理解其作用。
  3. filechoosewidget.cpp文件中,themeChanged函数中新增的代码应该有注释说明其目的,以便其他开发者理解其作用。

代码性能改进:

  1. installDebThread.cpp文件中,immutableProcess函数中的m_proc->setEnv调用应该检查m_proc是否为nullptr,以避免潜在的空指针解引用问题。
  2. immutable_backend.cpp文件中,ImmutableBackend类的构造函数中应该检查parent是否为nullptr,以避免潜在的空指针解引用问题。
  3. filechoosewidget.cpp文件中,themeChanged函数中新增的代码应该检查m_dndTips是否为nullptr,以避免潜在的空指针解引用问题。

代码安全性改进:

  1. installDebThread.cpp文件中,immutableProcess函数中的m_proc->setEnv调用应该验证kImmuEnvEnableWait的值,以防止潜在的注入攻击。
  2. immutable_backend.cpp文件中,ImmutableBackend类的构造函数中应该验证parent的值,以防止潜在的注入攻击。
  3. filechoosewidget.cpp文件中,themeChanged函数中新增的代码应该验证m_dndTips的值,以防止潜在的注入攻击。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union rb-union merged commit bcd9dc3 into linuxdeepin:master Dec 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants