Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uab use absolute path #284

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix: uab use absolute path #284

merged 1 commit into from
Nov 28, 2024

Conversation

rb-union
Copy link
Contributor

Use absolute path instead of relative path
when install/uninstall UAB package.

Log: UAB use absolute path
Influence: uab-pacakge

Use absolute path instead of relative path
when install/uninstall UAB package.

Log: UAB use absolute path
Influence: uab-pacakge
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码修改将 uabPtr->filePath 的赋值从 uabPath 改为 info.absoluteFilePath(),需要确认 info 对象是否在上下文中被正确初始化和使用。

是否建议立即修改:

  • 是,需要确保 info 对象的初始化和使用是正确的,以避免潜在的空指针异常或逻辑错误。如果 info 对象未正确初始化,应立即修复。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@starhcq
Copy link
Contributor

starhcq commented Nov 28, 2024

【是否满足兼容性要求】Y
【是否满足commit提交规范】Y
【是否满足编码规范】Y
【Review结论】Pass
【Fail原因】N/A

@rb-union rb-union merged commit 6f8f4ed into linuxdeepin:master Nov 28, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants