Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deepin-elf-verify or depends #257

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

rb-union
Copy link
Contributor

@rb-union rb-union commented Sep 4, 2024

Add deepin-elf-verfiy / deepin-elf-sign-tool or depends,
deepin-app-store-runtime is available in community edition.

Log: Add or depends on deepin-elf-verify.
Influence: debian/control

Copy link

github-actions bot commented Sep 4, 2024

[Debian检查]
检测到debian目录文件有变更: debian/control.uos debian/control debian/rules

@liujianqiang-niu
Copy link

不能通过rules文件判断版本,打包环境不确定。

Copy link

github-actions bot commented Sep 5, 2024

[Debian检查]
检测到debian目录文件有变更: debian/control

@rb-union rb-union changed the title feat: depends on deepin-elf-verify under the uos fix: deepin-elf-verify or depends Sep 5, 2024
@rb-union rb-union changed the title fix: deepin-elf-verify or depends feat: deepin-elf-verify or depends Sep 5, 2024
Add deepin-elf-verfiy / deepin-elf-sign-tool or depends,
deepin-app-store-runtime is available in community edition.

Log: Add or depends on deepin-elf-verify.
Influence: debian/control
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Depends字段中添加了deepin-app-store-runtime,但未提供该依赖项的详细信息,可能会导致依赖冲突。
  • 注释中提到了deepin-app-store-runtime在社区版中可用,但当前的依赖添加没有反映这种差异。
  • 新增了deepin-elf-verifydeepin-elf-sign-tool的依赖,但未说明这些工具的具体作用和用途。

是否建议立即修改:

  • 是,建议立即修改以解决依赖冲突和文档缺失的问题。同时,应该添加更多的上下文信息来解释新增依赖项的必要性和目的。

Copy link

github-actions bot commented Sep 5, 2024

[Debian检查]
检测到debian目录文件有变更: debian/control

@myk1343
Copy link

myk1343 commented Sep 5, 2024

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liujianqiang-niu, pengfeixx, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union rb-union merged commit 5a97ad9 into linuxdeepin:master Sep 5, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants