Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filemanagerwindow UI issue #2490

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

Lighto-Ku
Copy link
Contributor

Hide sidebar after playing animation for collapse it.

Log: fix UI issue

Hide sidebar after playing animation for collapse it.

Log: fix UI issue
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码中移除了对splitter handle的启用/禁用逻辑,可能会影响用户界面交互。
  • 新增了sideBar和sidebarSep的可见性设置,但未提供相应的注释说明为什么这样做。

是否建议立即修改:

  • 是,需要确保移除handle的启用/禁用逻辑不会对用户交互产生负面影响。
  • 是,建议添加注释说明为什么需要设置sideBar和sidebarSep的可见性,以便其他开发者理解这一变更的目的。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, Lighto-Ku

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs
Copy link
Contributor

/merge

@Johnson-zs
Copy link
Contributor

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 13, 2024

This pr cannot be merged! (status: blocked)

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 13, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 9fc9cff into linuxdeepin:master Dec 13, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants