refactor: Move dfmplugin-disk-encrypt from dde-filemanager-extensions #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning
详情 {
"export": {
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/gui/encryptparamsinputdialog.cpp": {
"b": [
" exportRecKeyEnabled = config_utils::exportKeyEnabled();",
" params.exportPath = keyExportInput->text();",
" \"you can decrypt the encrypted partition with the recovery key, please export it to \"",
" keyExportInput->setPlaceholderText(tr(\"Please select a non-encrypted partition as the key file export path.\"));",
" setMsg(tr(\"Recovery key export path cannot be empty!\"));",
" setMsg(tr(\"Recovery key export path is not exists!\"));",
" setMsg(tr(\"Please export to an external device such as a non-encrypted partition or USB flash drive.\"));",
" setMsg(tr(\"This partition is read-only, please export to a writable partition\"));",
" setMsg(tr(\"The partition is encrypted, please export to a non-encrypted \"",
" if (exportRecKeyEnabled) {",
" exportRecKeyEnabled ? addButton(tr(\"Next\")) : addButton(tr(\"Confirm encrypt\"));"
]
},
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/gui/encryptparamsinputdialog.h": {
"b": [
" bool exportRecKeyEnabled { false };"
]
},
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/gui/encryptprogressdialog.cpp": {
"b": [
" addButton(tr(\"Re-export the recovery key\"));",
" if (btnTxt != tr(\"Re-export the recovery key\"))",
" setMsg(tr(\"Recovery key export path cannot be empty!\"));",
" setMsg(tr(\"Recovery key export path is not exists!\"));",
" setMsg(tr(\"This partition is read-only, please export to a writable \"",
" setMsg(tr(\"The partition is encrypted, please export to a non-encrypted \""
]
},
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/menu/diskencryptmenuscene.cpp": {
"b": [
" { encrypt_param_keys::kKeyRecoveryExportPath, param.exportPath },",
" { encrypt_param_keys::kKeyRecoveryExportPath, param.exportPath },"
]
}
}
} |
|
Note
详情{
"examples/dfmplugin-encrypt-manager-demo/mainwindow.cpp": [
{
"line": " const QString password = \"Qwer@1234\";",
"line_number": 104,
"rule": "S106",
"reason": "Var naming | cafae82bb6"
}
],
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/diskencryptentry.json": [
{
"line": " \"UrlLink\" : \"https://www.uniontech.com\",",
"line_number": 11,
"rule": "S35",
"reason": "Url link | 3c9a9fccb6"
}
],
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/events/eventshandler.cpp": [
{
"line": " *pwd = acquirePassphraseByRec(dev, *cancelled);",
"line_number": 335,
"rule": "S28",
"reason": "Suspicious password declaration | c7753508fa"
},
{
"line": " *pwd = acquirePassphraseByPIN(dev, *cancelled);",
"line_number": 342,
"rule": "S28",
"reason": "Suspicious password declaration | 4cdcd2dd34"
},
{
"line": " *pwd = acquirePassphraseByTPM(dev, *cancelled);",
"line_number": 345,
"rule": "S28",
"reason": "Suspicious password declaration | 1db15c632e"
},
{
"line": " *pwd = acquirePassphraseByRec(dev, *cancelled);",
"line_number": 366,
"rule": "S28",
"reason": "Suspicious password declaration | c7753508fa"
}
],
"src/plugins/filemanager/dfmplugin-encrypt-manager/encryptmanager.json": [
{
"line": " \"UrlLink\" : \"https://www.uniontech.com\",",
"line_number": 11,
"rule": "S35",
"reason": "Url link | 3c9a9fccb6"
}
],
"debian/control": [
{
"line": "Homepage: http://www.deepin.org",
"line_number": 68,
"rule": "S35",
"reason": "Url link | 6fe814dfb7"
}
]
} |
|
Warning
详情 {
"export": {
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/gui/encryptparamsinputdialog.cpp": {
"b": [
" exportRecKeyEnabled = config_utils::exportKeyEnabled();",
" params.exportPath = keyExportInput->text();",
" \"you can decrypt the encrypted partition with the recovery key, please export it to \"",
" keyExportInput->setPlaceholderText(tr(\"Please select a non-encrypted partition as the key file export path.\"));",
" setMsg(tr(\"Recovery key export path cannot be empty!\"));",
" setMsg(tr(\"Recovery key export path is not exists!\"));",
" setMsg(tr(\"Please export to an external device such as a non-encrypted partition or USB flash drive.\"));",
" setMsg(tr(\"This partition is read-only, please export to a writable partition\"));",
" setMsg(tr(\"The partition is encrypted, please export to a non-encrypted \"",
" if (exportRecKeyEnabled) {",
" exportRecKeyEnabled ? addButton(tr(\"Next\")) : addButton(tr(\"Confirm encrypt\"));"
]
},
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/gui/encryptparamsinputdialog.h": {
"b": [
" bool exportRecKeyEnabled { false };"
]
},
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/gui/encryptprogressdialog.cpp": {
"b": [
" addButton(tr(\"Re-export the recovery key\"));",
" if (btnTxt != tr(\"Re-export the recovery key\"))",
" setMsg(tr(\"Recovery key export path cannot be empty!\"));",
" setMsg(tr(\"Recovery key export path is not exists!\"));",
" setMsg(tr(\"This partition is read-only, please export to a writable \"",
" setMsg(tr(\"The partition is encrypted, please export to a non-encrypted \""
]
},
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/menu/diskencryptmenuscene.cpp": {
"b": [
" { encrypt_param_keys::kKeyRecoveryExportPath, param.exportPath },",
" { encrypt_param_keys::kKeyRecoveryExportPath, param.exportPath },"
]
}
}
} |
|
Note
详情{
"examples/dfmplugin-encrypt-manager-demo/mainwindow.cpp": [
{
"line": " const QString password = \"Qwer@1234\";",
"line_number": 104,
"rule": "S106",
"reason": "Var naming | cafae82bb6"
}
],
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/diskencryptentry.json": [
{
"line": " \"UrlLink\" : \"https://www.uniontech.com\",",
"line_number": 11,
"rule": "S35",
"reason": "Url link | 3c9a9fccb6"
}
],
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/events/eventshandler.cpp": [
{
"line": " *pwd = acquirePassphraseByRec(dev, *cancelled);",
"line_number": 335,
"rule": "S28",
"reason": "Suspicious password declaration | c7753508fa"
},
{
"line": " *pwd = acquirePassphraseByPIN(dev, *cancelled);",
"line_number": 342,
"rule": "S28",
"reason": "Suspicious password declaration | 4cdcd2dd34"
},
{
"line": " *pwd = acquirePassphraseByTPM(dev, *cancelled);",
"line_number": 345,
"rule": "S28",
"reason": "Suspicious password declaration | 1db15c632e"
},
{
"line": " *pwd = acquirePassphraseByRec(dev, *cancelled);",
"line_number": 366,
"rule": "S28",
"reason": "Suspicious password declaration | c7753508fa"
}
],
"src/plugins/filemanager/dfmplugin-encrypt-manager/encryptmanager.json": [
{
"line": " \"UrlLink\" : \"https://www.uniontech.com\",",
"line_number": 11,
"rule": "S35",
"reason": "Url link | 3c9a9fccb6"
}
],
"debian/control": [
{
"line": "Homepage: http://www.deepin.org",
"line_number": 68,
"rule": "S35",
"reason": "Url link | 6fe814dfb7"
}
]
} |
itsXuSt
approved these changes
Dec 5, 2024
Move dfmplugin-disk-encrypt from dde-filemanager-extensions Log:
|
Warning
详情 {
"export": {
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/gui/encryptparamsinputdialog.cpp": {
"b": [
" exportRecKeyEnabled = config_utils::exportKeyEnabled();",
" params.exportPath = keyExportInput->text();",
" \"you can decrypt the encrypted partition with the recovery key, please export it to \"",
" keyExportInput->setPlaceholderText(tr(\"Please select a non-encrypted partition as the key file export path.\"));",
" setMsg(tr(\"Recovery key export path cannot be empty!\"));",
" setMsg(tr(\"Recovery key export path is not exists!\"));",
" setMsg(tr(\"Please export to an external device such as a non-encrypted partition or USB flash drive.\"));",
" setMsg(tr(\"This partition is read-only, please export to a writable partition\"));",
" setMsg(tr(\"The partition is encrypted, please export to a non-encrypted \"",
" if (exportRecKeyEnabled) {",
" exportRecKeyEnabled ? addButton(tr(\"Next\")) : addButton(tr(\"Confirm encrypt\"));"
]
},
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/gui/encryptparamsinputdialog.h": {
"b": [
" bool exportRecKeyEnabled { false };"
]
},
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/gui/encryptprogressdialog.cpp": {
"b": [
" addButton(tr(\"Re-export the recovery key\"));",
" if (btnTxt != tr(\"Re-export the recovery key\"))",
" setMsg(tr(\"Recovery key export path cannot be empty!\"));",
" setMsg(tr(\"Recovery key export path is not exists!\"));",
" setMsg(tr(\"This partition is read-only, please export to a writable \"",
" setMsg(tr(\"The partition is encrypted, please export to a non-encrypted \""
]
},
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/menu/diskencryptmenuscene.cpp": {
"b": [
" { encrypt_param_keys::kKeyRecoveryExportPath, param.exportPath },",
" { encrypt_param_keys::kKeyRecoveryExportPath, param.exportPath },"
]
}
}
} |
|
Note
详情{
"examples/dfmplugin-encrypt-manager-demo/mainwindow.cpp": [
{
"line": " const QString password = \"Qwer@1234\";",
"line_number": 104,
"rule": "S106",
"reason": "Var naming | cafae82bb6"
}
],
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/diskencryptentry.json": [
{
"line": " \"UrlLink\" : \"https://www.uniontech.com\",",
"line_number": 11,
"rule": "S35",
"reason": "Url link | 3c9a9fccb6"
}
],
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/events/eventshandler.cpp": [
{
"line": " *pwd = acquirePassphraseByRec(dev, *cancelled);",
"line_number": 335,
"rule": "S28",
"reason": "Suspicious password declaration | c7753508fa"
},
{
"line": " *pwd = acquirePassphraseByPIN(dev, *cancelled);",
"line_number": 342,
"rule": "S28",
"reason": "Suspicious password declaration | 4cdcd2dd34"
},
{
"line": " *pwd = acquirePassphraseByTPM(dev, *cancelled);",
"line_number": 345,
"rule": "S28",
"reason": "Suspicious password declaration | 1db15c632e"
},
{
"line": " *pwd = acquirePassphraseByRec(dev, *cancelled);",
"line_number": 366,
"rule": "S28",
"reason": "Suspicious password declaration | c7753508fa"
}
],
"src/plugins/filemanager/dfmplugin-encrypt-manager/encryptmanager.json": [
{
"line": " \"UrlLink\" : \"https://www.uniontech.com\",",
"line_number": 11,
"rule": "S35",
"reason": "Url link | 3c9a9fccb6"
}
],
"debian/control": [
{
"line": "Homepage: http://www.deepin.org",
"line_number": 68,
"rule": "S35",
"reason": "Url link | 6fe814dfb7"
}
]
} |
|
Warning
详情 {
"export": {
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/gui/encryptparamsinputdialog.cpp": {
"b": [
" exportRecKeyEnabled = config_utils::exportKeyEnabled();",
" params.exportPath = keyExportInput->text();",
" \"you can decrypt the encrypted partition with the recovery key, please export it to \"",
" keyExportInput->setPlaceholderText(tr(\"Please select a non-encrypted partition as the key file export path.\"));",
" setMsg(tr(\"Recovery key export path cannot be empty!\"));",
" setMsg(tr(\"Recovery key export path is not exists!\"));",
" setMsg(tr(\"Please export to an external device such as a non-encrypted partition or USB flash drive.\"));",
" setMsg(tr(\"This partition is read-only, please export to a writable partition\"));",
" setMsg(tr(\"The partition is encrypted, please export to a non-encrypted \"",
" if (exportRecKeyEnabled) {",
" exportRecKeyEnabled ? addButton(tr(\"Next\")) : addButton(tr(\"Confirm encrypt\"));"
]
},
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/gui/encryptparamsinputdialog.h": {
"b": [
" bool exportRecKeyEnabled { false };"
]
},
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/gui/encryptprogressdialog.cpp": {
"b": [
" addButton(tr(\"Re-export the recovery key\"));",
" if (btnTxt != tr(\"Re-export the recovery key\"))",
" setMsg(tr(\"Recovery key export path cannot be empty!\"));",
" setMsg(tr(\"Recovery key export path is not exists!\"));",
" setMsg(tr(\"This partition is read-only, please export to a writable \"",
" setMsg(tr(\"The partition is encrypted, please export to a non-encrypted \""
]
},
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/menu/diskencryptmenuscene.cpp": {
"b": [
" { encrypt_param_keys::kKeyRecoveryExportPath, param.exportPath },",
" { encrypt_param_keys::kKeyRecoveryExportPath, param.exportPath },"
]
}
}
} |
|
Note
详情{
"examples/dfmplugin-encrypt-manager-demo/mainwindow.cpp": [
{
"line": " const QString password = \"Qwer@1234\";",
"line_number": 104,
"rule": "S106",
"reason": "Var naming | cafae82bb6"
}
],
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/diskencryptentry.json": [
{
"line": " \"UrlLink\" : \"https://www.uniontech.com\",",
"line_number": 11,
"rule": "S35",
"reason": "Url link | 3c9a9fccb6"
}
],
"src/plugins/filemanager/dfmplugin-disk-encrypt-entry/events/eventshandler.cpp": [
{
"line": " *pwd = acquirePassphraseByRec(dev, *cancelled);",
"line_number": 335,
"rule": "S28",
"reason": "Suspicious password declaration | c7753508fa"
},
{
"line": " *pwd = acquirePassphraseByPIN(dev, *cancelled);",
"line_number": 342,
"rule": "S28",
"reason": "Suspicious password declaration | 4cdcd2dd34"
},
{
"line": " *pwd = acquirePassphraseByTPM(dev, *cancelled);",
"line_number": 345,
"rule": "S28",
"reason": "Suspicious password declaration | 1db15c632e"
},
{
"line": " *pwd = acquirePassphraseByRec(dev, *cancelled);",
"line_number": 366,
"rule": "S28",
"reason": "Suspicious password declaration | c7753508fa"
}
],
"src/plugins/filemanager/dfmplugin-encrypt-manager/encryptmanager.json": [
{
"line": " \"UrlLink\" : \"https://www.uniontech.com\",",
"line_number": 11,
"rule": "S35",
"reason": "Url link | 3c9a9fccb6"
}
],
"debian/control": [
{
"line": "Homepage: http://www.deepin.org",
"line_number": 68,
"rule": "S35",
"reason": "Url link | 6fe814dfb7"
}
]
} |
Clauszy
approved these changes
Dec 5, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Clauszy, itsXuSt, Johnson-zs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move dfmplugin-disk-encrypt from dde-filemanager-extensions
Log: