Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switching unresponsive in technical preview #20

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

robertkill
Copy link
Contributor

Remove input method support and related code
Remove package installation operation

Log:
pms: BUG-282157

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, robertkill

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Remove input method support and related code
Remove package installation operation

Log:
pms: BUG-282157
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. dccinsider.cpp:

    • setCurrentItem函数中,移除了对fcitx5deepin-im的支持,但未更新相关的文档或注释,应确保文档与代码保持同步。
    • 移除了对inputMethodChanged信号的连接,但未移除相关的信号声明,应检查是否有其他地方使用了该信号。
  2. insiderworker.cpp:

    • 移除了对inputMethod的支持,但未移除相关的成员变量m_inputMethodm_pkProxy,应确保移除所有与inputMethod相关的代码。
    • installPackage函数被移除,但未移除相关的调用,应检查是否有其他地方调用了该函数。
    • checkEnabledInputMethod函数被移除,但未移除相关的调用,应检查是否有其他地方调用了该函数。
    • switchInputMethod函数被移除,但未移除相关的调用,应检查是否有其他地方调用了该函数。
    • installDDEShell函数被移除,但未移除相关的调用,应检查是否有其他地方调用了该函数。
  3. insiderworker.h:

    • 移除了对inputMethod的支持,但未移除相关的函数声明,应确保移除所有与inputMethod相关的函数声明。
  4. pkpackagesproxy.cpppkpackagesproxy.h:

    • 这些文件被完全删除,但未更新相关的文档或注释,应确保文档与代码保持同步。
  5. main.qml:

    • 移除了对treeland输入法的支持,但未更新相关的文档或注释,应确保文档与代码保持同步。
  6. debian/changelog:

    • 更新了版本号,但未提供更新的详细说明,应提供更新的详细说明以便于理解变更内容。

总体来说,代码的修改较大,需要确保所有相关的部分都被正确更新,并且移除的代码部分没有在其他地方被使用。同时,应确保文档和注释与代码保持同步,以便其他开发者能够理解代码的变更。

Copy link

TAG Bot

TAG: 0.1.6
EXISTED: no
DISTRIBUTION: unstable

@robertkill
Copy link
Contributor Author

/topic dcc-insider-20241128

@deepin-ci-robot
Copy link

Add topic: dcc-insider-20241128 successed.

@robertkill
Copy link
Contributor Author

/integr-topic dcc-insider-20241128

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#2290

@robertkill
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Nov 28, 2024

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 519f6d0 into linuxdeepin:master Nov 28, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants