Skip to content

Commit

Permalink
Don't let a missing crypttab file cause tests to fail.
Browse files Browse the repository at this point in the history
  • Loading branch information
@dwlehman
dwlehman committed Feb 8, 2021
1 parent c899ef9 commit fb717ce
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tests/verify-role-results.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
command: cat /etc/crypttab
register: storage_test_crypttab
changed_when: false
failed_when: false

#
# Verify pools and the volumes they contain.
Expand Down

3 comments on commit fb717ce

@pcahyna
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dwlehman , do you know why is /etc/cryptab missing? Isn't it a bug?

@dwlehman
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dwlehman , do you know why is /etc/cryptab missing? Isn't it a bug?

I don't think so. I think the file is optional when there are no encrypted volumes the system is expected to set up automatically.

@pcahyna
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I checked as well. This file is normally in the systemd package, so it is supposed to be present. Our cloud images do not have it since (and including) 8.4, it used to exist before (8.3), I don't know why, but it is not a problem in the role (it is missing before the role runs) and IMO not worth investigating. Thanks for the change.

Please sign in to comment.