feat: add support mounting/unmounting snapshots and origins #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
trgill
force-pushed
the
mount_unmount
branch
3 times, most recently
from
49a739a to
35c1245
Compare
|
[citest] |
spetrosi
reviewed
Feb 12, 2024
trgill
force-pushed
the
mount_unmount
branch
2 times, most recently
from
60b9744 to
edfc1aa
Compare
|
[citest] |
trgill
force-pushed
the
mount_unmount
branch
from
edfc1aa to
bcec7da
Compare
|
[citest] |
trgill
force-pushed
the
mount_unmount
branch
2 times, most recently
from
9270f60 to
6b79b9e
Compare
richm
reviewed
Feb 12, 2024
richm
reviewed
Feb 12, 2024
richm
reviewed
Feb 12, 2024
richm
reviewed
Feb 12, 2024
richm
reviewed
Feb 12, 2024
richm
reviewed
Feb 12, 2024
richm
reviewed
Feb 12, 2024
richm
reviewed
Feb 12, 2024
trgill
force-pushed
the
mount_unmount
branch
3 times, most recently
from
d360002 to
ff3aa80
Compare
support the following role variables: snapshot_lvm_mount_origin snapshot_lvm_mountpoint_create snapshot_lvm_unmount_multiple snapshot_lvm_mountpoint snapshot_lvm_mount_options add mount/umount commands to the snapshot CLI. add basic tests for functionallity Signed-off-by: Todd Gill <[email protected]> Co-authored-by: Richard Megginson <[email protected]>
trgill
force-pushed
the
mount_unmount
branch
from
ff3aa80 to
791d32e
Compare
|
[citest] |
|
[citest bad] |
richm
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement:
support the following role variables:
snapshot_lvm_mount_origin
snapshot_lvm_mountpoint_create
snapshot_lvm_unmount_multiple
snapshot_lvm_mountpoint
snapshot_lvm_mount_options
add mount/umount commands to the snapshot CLI.
add basic tests for functionallity
Reason:
MVP requirement to manage mounts/unmounts of snapshots and origins
Result:
requirement satisfied
Issue Tracker Tickets (Jira or BZ if any):