fix: minor syntactical refinements from code review

linux-system-roles · Aug 21, 2024 · 9f46acf · 9f46acf
1 parent 18a5d58
commit 9f46acf
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/tasks/firewall.yml b/tasks/firewall.yml
@@ -21,7 +21,7 @@
         __metrics_firewall: "{{ __metrics_firewall |
             union([{'port': '44322/tcp', 'state': 'enabled'}]) }}"
       when:
-        - metrics_graph_service|bool or metrics_query_service|bool
+        - metrics_graph_service | bool or metrics_query_service|bool
 
     - name: Service for grafana
       set_fact:
@@ -35,15 +35,15 @@
         __metrics_firewall: "{{ __metrics_firewall |
             union([{'service': 'valkey', 'state': 'enabled'}]) }}"
       when:
-        - metrics_query_service|bool
+        - metrics_query_service | bool
         - ansible_facts['distribution_version'] is version('10', '>=')
 
     - name: Service for redis
       set_fact:
         __metrics_firewall: "{{ __metrics_firewall |
             union([{'service': 'redis', 'state': 'enabled'}]) }}"
       when:
-        - metrics_query_service|bool
+        - metrics_query_service | bool
         - ansible_facts['distribution_version'] is version('10', '<')
 
     - name: Ensure the service and the port status with the firewall role

diff --git a/tests/check_keyserver.yml b/tests/check_keyserver.yml
@@ -1,14 +1,5 @@
 # SPDX-License-Identifier: MIT
 ---
-- name: Check if Redis responds
-  shell: |
-    set -euo pipefail
-    redis-cli PING | grep PONG
-  changed_when: false
-  when: (ansible_distribution in ['RedHat', 'CentOS'] and
-         ansible_distribution_major_version | int > 6 and
-         ansible_distribution_major_version | int < 10)
-
 - name: Check if Valkey responds
   shell: |
     set -euo pipefail
@@ -17,3 +8,13 @@
   when: (ansible_distribution in ['RedHat', 'CentOS'] and
          ansible_distribution_major_version | int >= 10) or
          ansible_distribution not in ['RedHat', 'CentOS']
+
+- name: Check if Redis responds
+  shell: |
+    set -euo pipefail
+    redis-cli PING | grep PONG
+  changed_when: false
+  when:
+    - ansible_distribution in ['RedHat', 'CentOS']
+    - ansible_distribution_major_version | int > 6
+    - ansible_distribution_major_version | int < 10