Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crmsh corosync jinja2 template rework #212

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

marcelmamula
Copy link
Contributor

Enhancement:

  • Remove predefined parameters from corosync j2 template for crmsh that were assigning default value
  • Reuse existing corosync variables similar to pcs task

Reason:

  • Remove dependency on SAP and provide cleaner and lightweight corosync.conf

Result:

  • Successfully tested on SLES15 SP5 for SAP HANA and SAP ASCS clusters.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.50%. Comparing base (b0f0f96) to head (63aefe1).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   68.50%   68.50%           
=======================================
  Files           3        3           
  Lines         181      181           
=======================================
  Hits          124      124           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richm richm merged commit fd1bfc7 into linux-system-roles:main Jul 2, 2024
21 checks passed
@marcelmamula marcelmamula deleted the corosync branch July 23, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants