feat: support for ostree systems #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[citest] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 80.45% 80.45%
=======================================
Files 3 3
Lines 133 133
=======================================
Hits 107 107
Misses 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
richm
force-pushed
the
ostree
branch
2 times, most recently
from
ba18388 to
a00dda5
Compare
|
[citest] |
tomjelinek
reviewed
Nov 9, 2023
tomjelinek
approved these changes
Nov 9, 2023
Feature: Allow running and testing the role with ostree managed nodes. Reason: We have users who want to use the role to manage ostree systems. Result: Users can use the role to manage ostree managed nodes. Signed-off-by: Rich Megginson <[email protected]>
richm
commented
Nov 10, 2023
|
|
||
| - name: Make sure qnetd config files are not present | ||
| file: | ||
| path: /etc/corosync/qnetd | ||
| state: absent | ||
| when: ansible_facts.pkg_mgr | d() != "ansible.posix.rhel_rpm_ostree" |
There was a problem hiding this comment.
@tomjelinek this was one of the things I had to add to make ostree happy - apparently when it is added back it loses the ownership
There was a problem hiding this comment.
@richm Oh, I see. I created a ticket https://issues.redhat.com/browse/RHEL-16343
richm
commented
Nov 10, 2023
|
[citest] |
tomjelinek
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Allow running and testing the role with ostree managed nodes.
Reason: We have users who want to use the role to manage ostree
systems.
Result: Users can use the role to manage ostree managed nodes.
Signed-off-by: Rich Megginson [email protected]