Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix core dump issue when disabling HAVE_IBV_WR_API #304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tianx666
Copy link

When using rdma-core-v44, and compile perftest with "bash autoconfig; configure --disable-ibv_wr_api; make", then run a test. A core dump will ocur while ctx->dci_stream_id[i] is not allocted but assigned 0.

@sshaulnv
Copy link
Contributor

sshaulnv commented Jan 5, 2025

Hi @tianx666, thanks for your contribution!

This change will not fully resolve the issue, as there are additional instances where dci_stream_id is accessed and also HAVE_IBV_WR_API is not directly related to it.
Since this variable is specific to the DC connection type, a more appropriate approach would be to add a check for the selected connection type before accessing it.

@tianx666 tianx666 force-pushed the master branch 2 times, most recently from 72bf8de to bb7115b Compare January 9, 2025 03:11
@tianx666
Copy link
Author

tianx666 commented Jan 9, 2025

Hi,@sshaulnv
As for accessing dci_stream_id, all other instances are inside new_post_send, which is controlled by HAVE_IBV_WR_API, so there should be no issues.
The code here is just to initialize dci_stream_id to 0 in ctx_init, so it would be better to initialize it directly after allocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants