For linux msm/flashing progress #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than sprinkling the user experience decisions across the implementation with prints to stdout, stderr, conditional checks for qdl_debug etc, consolidate these into a single set of ux wrappers. Transition all callers of printf() and fprintf() to these new wrappers, without changing the level of content of the printouts. Signed-off-by: Bjorn Andersson <[email protected]>
QDL uses a few different styles when printing logs for the user, with some inconsistencies, some errors, and some room for improvement. Revisit all the ux_xyz() invocations to clean up the output from the tool. Signed-off-by: Bjorn Andersson <[email protected]>
Not providing any user feedback during flashing is not very user friendly, in particular when, in some situations, it can take minutes to flash very large files. Introduce a progress bar for the flashing and patching steps to provide such feedback to the user, when stdout is determined to be a terminal of sufficient size (i.e. tools programmatically invoking qdl should see no difference). Signed-off-by: Bjorn Andersson <[email protected]>
andersson
force-pushed
the
for-linux-msm/flashing-progress
branch
from
a8f6fb6 to
b080ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long pending overhaul of the mix of things being generated on stdout/stderr...