tacd: update dependencies by hand #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops. Good thing we have the CI jobs for different configurations and rust versions. Looks like I have some homework to do. Marked as Draft until I get around to it. |
hnez
force-pushed
the
cargo-update-2024-11-15
branch
from
d34cf7f
to
5a3904d
Compare
We no longer need to build new tacd versions on nanbield, so we can drop the check. We do however need to build on the new styhead yocto release, so add a check for its rust version. Signed-off-by: Leonard Göhrs <[email protected]>
Signed-off-by: Leonard Göhrs <[email protected]>
They are not a direct dependency of ours so there is not a lot we can do about it. The "derivative" create is brought in by the "zbus" dependency. The "instant" crate is brought in by "futures-light". Signed-off-by: Leonard Göhrs <[email protected]>
Signed-off-by: Leonard Göhrs <[email protected]>
The new zbus version (4.2) is not the newest available version (5.1.1) because the newer version has a minimum supported rust version of 1.80, which is newer than the rust version available in yocto scarthgap. The update gets rid of the unmaintained "derivative" dependency causing cargo deny error RUSTSEC-2024-0388. Signed-off-by: Leonard Göhrs <[email protected]>
The `LineRequestFlags` struct is no longer `Copy` in version 0.6.0, which is why we need to `.clone()` it explicitly. Signed-off-by: Leonard Göhrs <[email protected]>
Go through our dependencies, check their most recent version on crates.io and update to that. Signed-off-by: Leonard Göhrs <[email protected]>
hnez
force-pushed
the
cargo-update-2024-11-15
branch
from
5a3904d
to
082b501
Compare
|
I've fixed the issues that made the CI checks fail. For that I've borrowed a commit from #83 that replaces the rust version check for rust 1.70 (used in Yocto nanbield) with one for rust 1.79 (used in Yocto styhead). |
This was referenced Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the periodic
cargo denyjobs have started failing due to two new unmaintained transitive dependencies of ours.One of them (RUSTSEC-2024-0384) is caused by tide and will likely not go away until we migrate away from it.
But the other one (RUSTSEC-2024-0388) was fixable by updating the
zbusdependency.That required some manual migration work and re-introspecting the DBus services on the TAC using
zbus-xmlgenbut was due anyways.I've also updated other dependencies that had new major versions available and where thus not covered by
cargo updatealone.TODO before merging: