web: display notifications for actions that can only be done on commandline #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Totally agree here. For something that is probably done only once for a device it should be OK to ask the user to complete it on the command line - especially since SSH access is part of the onboarding process. |
hnez
force-pushed
the
cmdline-notifications
branch
from
48d004c
to
ffaf872
Compare
This will allow us to add e.g. React `useState`'s that are used by the whole application in the future. Signed-off-by: Leonard Göhrs <[email protected]>
The App.test.tsx file was created by create-react-app when initially setting up the project. It has not been updated or used since then though. If the parameters of the `App` function ever where to change (foreshadowing) the build would break, requiring changes to App.test.tsx. Since the file is unused it can just be removed instead. Signed-off-by: Leonard Göhrs <[email protected]>
Implementing active rauc slot chaning safely would be quite difficult and it is also not something users would do regularly. Display a notification at the top of the screen instead. The notifications contains the correct command line to perform the desired change. Signed-off-by: Leonard Göhrs <[email protected]>
Implementing the update channel actication/deactivation safely would be somewhat involved. Display a notification on the commandline instead that shows how to do the change. Signed-off-by: Leonard Göhrs <[email protected]>
hnez
force-pushed
the
cmdline-notifications
branch
from
ffaf872
to
30196cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two things in the web interface that look like they can be used to change a piece of configuration but actually can't:
As @a3f (I think) rightfully stated this is a bit confusing to the user,
but actually implementing such actions (in a somewhat safe way) would be quite a lot of work and performing these actions is not something a user would do regularly.
Instead display a notification when one of the actions is requested that looks something like this: