disable MAEv4 emission by default (#291)

* disable MAEv4 emission by default * fix tests * fix test * fix test --------- Co-authored-by: Jesse Jia <[email protected]>
linkedin · Aug 17, 2023 · ddd3f0d · ddd3f0d
1 parent 17f4142
commit ddd3f0d
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/dao-api/src/main/java/com/linkedin/metadata/dao/BaseLocalDAO.java b/dao-api/src/main/java/com/linkedin/metadata/dao/BaseLocalDAO.java
@@ -170,7 +170,7 @@ public static class AspectUpdateLambda<ASPECT extends RecordTemplate> {
   // Enable updating multiple aspects within a single transaction
   private boolean _enableAtomicMultipleUpdate = false;
 
-  private boolean _emitAuditEvent = true;
+  private boolean _emitAuditEvent = false;
 
   private Clock _clock = Clock.systemUTC();
 

diff --git a/dao-api/src/test/java/com/linkedin/metadata/dao/BaseLocalDAOTest.java b/dao-api/src/test/java/com/linkedin/metadata/dao/BaseLocalDAOTest.java
@@ -216,6 +216,7 @@ public void setup() {
     _mockTrackingManager = mock(BaseTrackingManager.class);
     _mockTransactionRunner = spy(DummyTransactionRunner.class);
     _dummyLocalDAO = new DummyLocalDAO(_mockGetLatestFunction, _mockEventProducer, _mockTransactionRunner);
+    _dummyLocalDAO.setEmitAuditEvent(true);
     _dummyAuditStamp = makeAuditStamp("foo", 1234);
   }
 
@@ -311,6 +312,7 @@ public void testMAEv5WithTracking() throws URISyntaxException {
     IngestionTrackingContext mockTrackingContext = mock(IngestionTrackingContext.class);
     DummyLocalDAO dummyLocalDAO = new DummyLocalDAO(_mockGetLatestFunction, _mockTrackingEventProducer, _mockTrackingManager,
         _dummyLocalDAO._transactionRunner);
+    dummyLocalDAO.setEmitAuditEvent(true);
     dummyLocalDAO.setAlwaysEmitAuditEvent(true);
     dummyLocalDAO.setEmitAspectSpecificAuditEvent(true);
     dummyLocalDAO.setAlwaysEmitAspectSpecificAuditEvent(true);

diff --git a/dao-impl/ebean-dao/src/test/java/com/linkedin/metadata/dao/EbeanLocalDAOTest.java b/dao-impl/ebean-dao/src/test/java/com/linkedin/metadata/dao/EbeanLocalDAOTest.java
@@ -192,6 +192,7 @@ private <URN extends Urn> EbeanLocalDAO<EntityAspectUnion, URN> createDao(@Nonnu
     if (urnClass == BarUrn.class) {
       dao.setUrnPathExtractor((UrnPathExtractor<URN>) new BarUrnPathExtractor());
     }
+    dao.setEmitAuditEvent(true);
     return dao;
   }
 

diff --git a/version.properties b/version.properties
@@ -1 +1 @@
-version=0.3.*
+version=0.4.*