add more unit test for the default value behavior (#474)

Co-authored-by: Zihan Li <[email protected]>
linkedin · Nov 12, 2024 · 14ff8c8 · 14ff8c8
1 parent 017f037
commit 14ff8c8
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/dao-impl/ebean-dao/src/test/java/com/linkedin/metadata/dao/utils/EBeanDAOUtilsTest.java b/dao-impl/ebean-dao/src/test/java/com/linkedin/metadata/dao/utils/EBeanDAOUtilsTest.java
@@ -5,6 +5,7 @@
 import com.linkedin.data.template.RecordTemplate;
 import com.linkedin.data.template.StringArray;
 import com.linkedin.metadata.aspect.AuditedAspect;
+import com.linkedin.metadata.dao.BaseLocalDAO;
 import com.linkedin.metadata.dao.EbeanLocalAccess;
 import com.linkedin.metadata.dao.EbeanMetadataAspect;
 import com.linkedin.metadata.dao.ListResult;
@@ -22,8 +23,10 @@
 import com.linkedin.testing.AnnotatedRelationshipFoo;
 import com.linkedin.testing.AnnotatedRelationshipFooArray;
 import com.linkedin.testing.AspectFoo;
+import com.linkedin.testing.AspectWithDefaultValue;
 import com.linkedin.testing.CommonAspect;
 import com.linkedin.testing.CommonAspectArray;
+import com.linkedin.testing.MapValueRecord;
 import com.linkedin.testing.urn.BurgerUrn;
 import com.linkedin.testing.urn.FooUrn;
 import io.ebean.Ebean;
@@ -508,6 +511,25 @@ public void testToAndFromJson() throws NoSuchMethodException, InvocationTargetEx
     assertNotNull(RecordUtils.toRecordTemplate(AspectFoo.class, (String) extractAspectJsonString.invoke(EBeanDAOUtils.class, toJson)));
   }
 
+  @Test
+  public void testToAndFromJsonWithDefaultValue() throws NoSuchMethodException, InvocationTargetException, IllegalAccessException {
+    AuditedAspect auditedAspect = new AuditedAspect();
+    AspectWithDefaultValue defaultValueAspect = new AspectWithDefaultValue().setNestedValueWithDefault(new MapValueRecord());
+    BaseLocalDAO.validateAgainstSchemaAndFillinDefault(defaultValueAspect);
+    String actual = RecordUtils.toJsonString(defaultValueAspect);
+
+    auditedAspect.setLastmodifiedby("0");
+    auditedAspect.setLastmodifiedon("1");
+    auditedAspect.setAspect(RecordUtils.toJsonString(defaultValueAspect));
+    String toJson = EbeanLocalAccess.toJsonString(auditedAspect);
+
+    Method extractAspectJsonString = EBeanDAOUtils.class.getDeclaredMethod("extractAspectJsonString", String.class);
+    extractAspectJsonString.setAccessible(true);
+    assertEquals("{\"lastmodifiedon\":\"1\",\"aspect\":{\"nestedValueWithDefault\":{\"mapValueWithDefaultmap\":{}},"
+        + "\"valueWithDefault\":\"\"},\"lastmodifiedby\":\"0\"}", toJson);
+    assertNotNull(RecordUtils.toRecordTemplate(AspectFoo.class, (String) extractAspectJsonString.invoke(EBeanDAOUtils.class, toJson)));
+  }
+
   @Test
   public void testGetFromJdbc() {
 

diff --git a/testing/test-models/src/main/pegasus/com/linkedin/testing/AspectWithDefaultValue.pdl b/testing/test-models/src/main/pegasus/com/linkedin/testing/AspectWithDefaultValue.pdl
@@ -7,4 +7,5 @@ record AspectWithDefaultValue {
    */
   valueWithDefault: string = ""
   nestedValueWithDefault: record MapValueRecord {mapValueWithDefaultmap: map[string, string] = { }}
+  optionalValueWithDefualt: optional string = ""
 }