Revert [Coral-Trino] PR#442 Remove UnionSqlCallTransformer #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the set operation (linkedin#442)" This reverts commit 4bb38a1.
aastha25
changed the title
wmoustafa
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
This reverts commit 4bb38a1. [PR: https://github.com//pull/442 ]
OSS Trino community contributed a patch PR#442 to Cast char fields, if necessary, to varchar type to ensure that the char fields from the inner SELECT statements have the same type as the output field types of the set operation (example UNION). This code change has led to a large number of modifications in generated trino SQLs, which has introduced complexities in the review process of production datasets. To avoid any potential regression, this commit is being rolled back in the hotfix branch. The commit will be reexamined and reintroduced at a later point with a deployment plan.
How was this patch tested?
./gradlew build
i-tested against production views.