Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coral-Hive] Remove duplicate used defined function registration #463

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[Coral-Hive] Remove duplicate used defined function registration #463

merged 1 commit into from
Oct 23, 2023

Conversation

findinpath
Copy link
Contributor

@findinpath findinpath commented Oct 15, 2023 •
edited
Loading

What changes are proposed in this pull request, and why are they necessary?

Remove one of the duplicated registrations for array_contains user defined function definitions:

coral/coral-hive/src/main/java/com/linkedin/coral/hive/hive2rel/functions/StaticHiveFunctionRegistry.java

Line 363 in a7e33e6

createAddUserDefinedFunction("array_contains", ReturnTypes.BOOLEAN, family(SqlTypeFamily.ARRAY, SqlTypeFamily.ANY));

coral/coral-hive/src/main/java/com/linkedin/coral/hive/hive2rel/functions/StaticHiveFunctionRegistry.java

Line 376 in a7e33e6

createAddUserDefinedFunction("array_contains", ReturnTypes.BOOLEAN, family(SqlTypeFamily.ARRAY, SqlTypeFamily.ANY));

How was this patch tested?

N/A

@wmoustafa wmoustafa merged commit 761b209 into linkedin:master Oct 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmoustafa wmoustafa wmoustafa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@findinpath @wmoustafa