Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented word-lists generator from Wikivoyage categories #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Poslovitch
Copy link
Member

@Poslovitch Poslovitch commented Feb 21, 2021

Implements https://phabricator.wikimedia.org/T275297

Also added missing "default" properties in extension.json

IMPORTANT: this PR could not be tested locally. I'm in dire need of some documentation to install a MediaWiki instance on my end. We'll have to find someone able to test this PR.

BEFORE MERGING: Make sure to create a property on Lingua Libre. See the Phabricator task for more info about that. Done: lingua-libre/operations#3

@Poslovitch Poslovitch added the enhancement New feature or request label Feb 21, 2021
@Poslovitch Poslovitch marked this pull request as draft February 21, 2021 16:01
@hugolpz
Copy link
Member

hugolpz commented Feb 21, 2021

Poslovitch, since this new feature isn't within WikiValley mission I have no idea to who we could ask to test, accept, and deploy this PR. cc: @belett

Also. You rocks. 😄 🚀

Poslovitch added a commit to lingua-libre/operations that referenced this pull request Feb 22, 2021
@hugolpz hugolpz self-assigned this Mar 7, 2021
@hugolpz hugolpz marked this pull request as ready for review December 23, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants