Emoji picker example improvements #833
Conversation
|
Panic should be fixed by #834. |
jaredoconnell
force-pushed
the
emoji-picker-improvements
branch
from
5405e6d to
53af04e
Compare
|
|
||
| flex(( | ||
| // TODO: Expose that this is a previous page button to accessibility | ||
| button("<-", move |data| { | ||
| *data = current_start.saturating_sub(count_per_page); | ||
| (current_start != 0).then(|| { |
There was a problem hiding this comment.
Ideally, we'd disable the button instead of hiding it, but that's not currently exposed to Xilem (it will likely end up looking similar to transform)
There was a problem hiding this comment.
I had the same thought. Hopefully it won't be too much overhead to implement disabling widgets in the future.
There was a problem hiding this comment.
Whilst we're here, could we increase the font size on the buttons (which is possible since #797)
There was a problem hiding this comment.
Done. It looked bad so I got the idea of using emoji. This isn't great for universal compatibility, but of all examples this is the most appropriate. This may even help with default accessibility.
There was a problem hiding this comment.
(I also meant the buttons associated with each option)
There was a problem hiding this comment.
That makes sense. Pushed. It's definitely even better now.
Also increases the font size
Good to know. A long-term goal is definitely to improve responsiveness. I'll be available to review a follow up PR if you choose to do that. |
This PR includes improvements to page selector.
Specifically it now shows the full percentage range instead of just the start of it, and it hides the buttons when you reach the end of the range.
For some reason it panics when I get to the end.