Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use animation controller instead of animator #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maurerdietmar
Copy link
Collaborator

Doing cleanups in the animation subdir, I still wonder if that Animator class
is usable at all. Unfortunately the documentation is quite bad, and the code does not lock
very mature.

So I went to the provided example examples/animator.rs and tried to implement it myself.
Turn out it is quite easy to implement the same functionality without the Animator class.

So what exactly is the advantage of that Animator class?

This is a rewrite of example/animator.rs use AnimationController/AnimationCurve.

Signed-off-by: Dietmar Maurer <[email protected]>
@richard-uk1
Copy link
Collaborator

git blame tells me that @rjwittams wrote the animation code originally. Maybe he would like to comment..?

@rjwittams
Copy link
Collaborator

I don't really get the PR.
The point of the Animator is to run lots of different animations at once on various things.
I used it more extensively for charts in druid-table.
I'll have to catch back up with things as I've not been involved for quite a few months

@maurerdietmar
Copy link
Collaborator Author

I don't really get the PR.

My point is that I can do the same thing without the Animator class. I rewrote your example to show that.
I will take a look at druid-table to see how its used there. BTW, please can you add a LICENSE/COPYRIGHT to that repository.

Here are a view more question:

  • AnimationStorage: - wouldn't it easier to use a HashMap instead? Would you mind to document the purpose of that struct?
  • AnimationStatusInternal: Why exactly did you add that delay feature (add_delay)? Instead, one could simply use a delayed curve (https://api.flutter.dev/flutter/animation/Interval-class.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants