Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StreamMessage.timeout() #5761

Merged
merged 28 commits into from
Nov 7, 2024
Merged

Commits on Jun 25, 2024

  1. Configuration menu
    Copy the full SHA
    045afcc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5818e6c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    02cccc3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f47216e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1d8a37f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8cd5d4f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    926d53d View commit details
    Browse the repository at this point in the history
  8. Add TimeoutStreamMessageTest

    sjy982 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    4d0e10f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d1ea297 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    318ebf3 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Add timeout unscheduling logic to abort().

    Unsubscribing due to a timeout does not guarantee synchronization with upstream.
    
    Therefore, we implemented an attempt attemptTerminate() method.
    sjy982 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b095d33 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Create Java Docs,

    Lint error correction
    sjy982 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    621e141 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Applying reviews

    1. remove @throws from docs
    2. add @UnstableApi with timeout method
    3. public -> final
    4. add @nullable to timeoutSubscriber
    5. cancel() override (add cancelSchedule())
    6. lastontime nano -> lasteventtime nano
    7. createTimeoutSchedule -> scheduleTimeout
    8. call onError after canceling
    sjy982 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6c86d2f View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. 1. Delete aptTerminate Method -> Replace with completed

    2. onNext -> Delete isCancelled() from condition
    case UNTIL_FIRST:
    Change timeoutfuture.cancel(false)  to cancelSchedule()
    sjy982 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f8248a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b1d03c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. 1. replace 2019 with 2024

    2. add docs to StreamTimeoutMode parameter
    3. use test code executor.get()
    sjy982 committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    45008d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. 1. call delegate.onSubscribe() in TimeoutSubscriber's onSubscribe(), …

    …and set the timeout schedule
    
    2. change TimeoutSubscriber class to TimeoutStreamMessage's inner class
    sjy982 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    e4c3916 View commit details
    Browse the repository at this point in the history
  2. lint

    sjy982 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    13228b3 View commit details
    Browse the repository at this point in the history
  3. Remove blank lines

    sjy982 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    73adfff View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. 1. Add @UnstableApi to HttpResponse, HttpRequest, and `StreamTi…

    …meoutMode`
    
    2. Added leak prevention code when completed in onNext() - PooledObjects.close(t)
    sjy982 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    38b6eb9 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    566d725 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. 1. Modify JavaDoc

    2. Add a StreamTimeoutException
    3. Overriding WebSocket's timeout method
    4. Remove cancelSchedule() from abort()
    5. Set timeoutFuture to null to avoid calling .isCancelled() which may access a volatile field.
    6. Modify boolean cancels to volatile boolean cancels
    sjy982 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    eb8d450 View commit details
    Browse the repository at this point in the history
  2. lint pass

    sjy982 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    994ce96 View commit details
    Browse the repository at this point in the history
  3. lint pass

    sjy982 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    cdeec5c View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. javadoc

    ikhoon committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    a95f279 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    efb32b3 View commit details
    Browse the repository at this point in the history
  3. nullaway

    ikhoon committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    2560092 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    24245a4 View commit details
    Browse the repository at this point in the history